After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723777 - Non-void function should return a value
Non-void function should return a value
Status: RESOLVED FIXED
Product: libgda
Classification: Other
Component: general
unspecified
Other FreeBSD
: Normal normal
: ---
Assigned To: malerba
gnome-db Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-06 15:56 UTC by Ting-Wei Lan
Modified: 2014-02-11 20:21 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix "Non-void function should return a value" (1.53 KB, patch)
2014-02-06 15:56 UTC, Ting-Wei Lan 		none Details | Review

Description Ting-Wei Lan 2014-02-06 15:56:27 UTC 
Created attachment 268304 [details] [review]
Fix "Non-void function should return a value"

In libgda/gda-server-provider.c, function _gda_server_provider_get_impl_functions and gda_server_provider_get_impl_functions_for_class use g_return_if_fail, which should be replaced by g_return_val_if_fail.
Comment 1 malerba 2014-02-11 20:21:46 UTC 
Done, see https://git.gnome.org/browse/libgda/commit/?id=1d4b91f7b251b80f4e9137b51cbc87b8199cb6f7
Thanks for the bug report!