GNOME Bugzilla – Bug 723701
Critical warnings on start
Last modified: 2014-03-01 16:42:27 UTC
I did a 'jhbuild build gnome-software' today. I saw a bunch of critical warnings when I start gnome-software. I closed gnome-software launched again with G_DEBUG=fatal-criticals to get a backtrace, but the warnings didn't occur again. The first time I had to wait a while for all the images and programs on the start page to load, whereas the second time everything was cached and loaded immediately. (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'image-missing' for stock: Icon 'image-missing' not present in theme (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'image-missing' for stock: Icon 'image-missing' not present in theme (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'image-missing' for stock: Icon 'image-missing' not present in theme (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'image-missing' for stock: Icon 'image-missing' not present in theme (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'image-missing' for stock: Icon 'image-missing' not present in theme (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'image-missing' for stock: Icon 'image-missing' not present in theme (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'image-missing' for stock: Icon 'image-missing' not present in theme (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'help-about' for stock: Icon 'help-about' not present in theme (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'help-about' for stock: Icon 'help-about' not present in theme (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'help-about' for stock: Icon 'help-about' not present in theme (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'help-about' for stock: Icon 'help-about' not present in theme (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'help-about' for stock: Icon 'help-about' not present in theme (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'image-missing' for stock: Icon 'image-missing' not present in theme (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'image-missing' for stock: Icon 'image-missing' not present in theme (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'image-missing' for stock: Icon 'image-missing' not present in theme (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'image-missing' for stock: Icon 'image-missing' not present in theme (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'image-missing' for stock: Icon 'image-missing' not present in theme (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'image-missing' for stock: Icon 'image-missing' not present in theme (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): GLib-CRITICAL **: g_hash_table_lookup: assertion 'hash_table != NULL' failed (gnome-software:11853): Gtk-WARNING **: Error loading theme icon 'image-missing' for stock: Icon 'image-missing' not present in theme
Can you get a backtrace on the critical warning please?
Created attachment 270283 [details] Backtrace Sure. I rebuilt from master again today.
This might fix things: commit 6f4d6c8238bc267abd2d0adfb6e83695d989892c Author: Richard Hughes <richard@hughsie.com> Date: Tue Feb 25 14:43:51 2014 +0000 Warn when overwriting metadata keys that already exist Also, ignore setting an existing key with the same value as we're trying to set, we don't want the memory address to be changed for no reason. Resolves: https://bugzilla.gnome.org/show_bug.cgi?id=723702 :100644 100644 955a601... d7411ff... M src/gs-app.c Can you try again please. Thanks.
Do you have a way to clear/reset the metadata so that I can reproduce this reliably without the patch? I was getting the criticals this morning, but not any more.
"sudo rm /var/cache/PackageKit/* -rf" should do the trick.
Created attachment 270393 [details] New backtrace Still broken, backtrace looks mostly the same.
commit 6a3215403d04cfc99efbb5e04c8e84670d012342 Author: Richard Hughes <richard@hughsie.com> Date: Fri Feb 28 14:57:53 2014 +0000 Do not use gtk_icon_theme_load_icon() as it's not thread safe Resolves: https://bugzilla.gnome.org/show_bug.cgi?id=723701 Can you verify with master please? Thanks.
Created attachment 270616 [details] Backtrace #3 I'm not sure if that fixed it or not. I still hit a critical, but this one is different.
Ahh, that was the last patch from mclasen -- this fixes it up: commit 65181166cbc355fd91121afb568c79d50b9eca15 Author: Richard Hughes <richard@hughsie.com> Date: Sat Mar 1 14:35:57 2014 +0000 Don't connect to signals of the previously removed widgets
Seems good, thanks!