After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723696 - Add support for blockquote
Add support for blockquote
Status: RESOLVED FIXED
Product: gtk-doc
Classification: Platform
Component: general
unspecified
Other All
: Normal normal
: 1.20
Assigned To: gtk-doc maintainers
gtk-doc maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-05 17:06 UTC by William Jon McCann
Modified: 2014-02-06 12:56 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add support for markdown blockquotes (2.71 KB, patch)
2014-02-05 17:06 UTC, William Jon McCann
committed Details | Review
Add a more complex blockquote test (1.18 KB, patch)
2014-02-05 17:06 UTC, William Jon McCann
committed Details | Review
Use blockquote instead of note (1.30 KB, patch)
2014-02-05 17:06 UTC, William Jon McCann
committed Details | Review

Description William Jon McCann 2014-02-05 17:06:23 UTC
Here are patches to enable using > markdown for block quotes.
Comment 1 William Jon McCann 2014-02-05 17:06:25 UTC
Created attachment 268185 [details] [review]
Add support for markdown blockquotes
Comment 2 William Jon McCann 2014-02-05 17:06:34 UTC
Created attachment 268186 [details] [review]
Add a more complex blockquote test
Comment 3 William Jon McCann 2014-02-05 17:06:38 UTC
Created attachment 268187 [details] [review]
Use blockquote instead of note
Comment 4 Stefan Sauer (gstreamer, gtkdoc dev) 2014-02-06 08:46:36 UTC
Review of attachment 268185 [details] [review]:

::: gtkdoc-mkdb.in
@@ +4709,3 @@
+    if ($md_block->{"type"} eq "quote") {
+      if (!$md_block->{"interrupted"}) {
+        $line =~ s/^[ ]*>[ ]?//;

instead of [ ]* you can use \s* also below.

::: tests/gobject/src/gobject.c
@@ +49,3 @@
  *
+ * > This is a section with a heading without a trailing hash
+ * > mark. And content in a note block.

I'd probably have a plain para + the note:

This is a section with a heading without a trailing hash mark.

> And this is an important note.
Comment 5 Stefan Sauer (gstreamer, gtkdoc dev) 2014-02-06 09:20:15 UTC
Other than that, looks good too me.
Please squash the patches. The 3rd could go into the first and while the 2nd has the 'tests' the first one has some as well.

After that, please push.
Comment 6 William Jon McCann 2014-02-06 12:55:56 UTC
Attachment 268185 [details] pushed as 81f4447 - Add support for markdown blockquotes