After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723690 - Protect against spurious changed::view-as signals
Protect against spurious changed::view-as signals
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.10.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-02-05 16:06 UTC by Debarshi Ray
Modified: 2014-02-21 17:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Protect against spurious view-as signals (2.90 KB, patch)
2014-02-05 16:16 UTC, Debarshi Ray 		committed Details | Review
documents: Disconnect the handler from the correct instance (875 bytes, patch)
2014-02-21 13:34 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-02-05 16:06:33 UTC 
Looks like GSettings does will still emit 'changed::view-as' if I repeatedly click the same option in dconf-editor. Similarly, the GAction will keep emitting 'activated' if I repeatedly click the same option from the application menu (this was possible in 3.10.x, but not any more).

This leads to duplicate colums in the list view.
Comment 1 Debarshi Ray 2014-02-05 16:16:24 UTC 
Created attachment 268182 [details] [review]
Protect against spurious view-as signals
Comment 2 Cosimo Cecchi 2014-02-05 16:31:43 UTC 
Review of attachment 268182 [details] [review]:

Looks good
Comment 3 Debarshi Ray 2014-02-05 16:39:33 UTC 
Comment on attachment 268182 [details] [review]
Protect against spurious view-as signals

Thanks for the review.
Comment 4 Debarshi Ray 2014-02-05 16:39:51 UTC 
This problem has been fixed in our software repository. The fix will go into the next software release. Thank you for your bug report.
Comment 5 Debarshi Ray 2014-02-21 13:34:17 UTC 
Created attachment 269920 [details] [review]
documents: Disconnect the handler from the correct instance

Fallout from the previous patch.
Comment 6 Cosimo Cecchi 2014-02-21 17:10:15 UTC 
Review of attachment 269920 [details] [review]:

Oops, sure.
Comment 7 Debarshi Ray 2014-02-21 17:51:39 UTC 
Comment on attachment 269920 [details] [review]
documents: Disconnect the handler from the correct instance

Thanks for the review!