After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723629 - make distcheck fails
make distcheck fails
Status: RESOLVED FIXED
Product: gnome-maps
Classification: Applications
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-maps-maint
gnome-maps-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-04 20:13 UTC by Mattias Bengtsson
Modified: 2014-03-02 19:16 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix make distcheck (1.34 KB, patch)
2014-03-02 17:35 UTC, Mattias Bengtsson
committed Details | Review

Description Mattias Bengtsson 2014-02-04 20:13:51 UTC
When running make distcheck with current git master it fails with this error message:

make[1]: Entering directory `/home/mattiasb2/Code/gnome/gnome-maps/gnome-maps-3.11.4.1/_build'
Making all in src
../../src/gnome-maps.data.gresource.xml: Failed to locate 'app-menu.ui' in any source directory.
../../src/gnome-maps.data.gresource.xml: Failed to locate 'app-menu.ui' in any source directory.
make[2]: Entering directory `/home/mattiasb2/Code/gnome/gnome-maps/gnome-maps-3.11.4.1/_build/src'
  GEN      ../../src/path.js
/bin/sh: ../../src/path.js: Permission denied
make[2]: *** [../../src/path.js] Error 1
make[2]: Leaving directory `/home/mattiasb2/Code/gnome/gnome-maps/gnome-maps-3.11.4.1/_build/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/mattiasb2/Code/gnome/gnome-maps/gnome-maps-3.11.4.1/_build'
make: *** [distcheck] Error 1
Comment 1 Zeeshan Ali 2014-03-02 02:18:02 UTC
Mattias, you promised this will definitely be fixed by end of this week (i-e before Monday's release).
Comment 2 Mattias Bengtsson 2014-03-02 13:36:47 UTC
Yep working on it today.
Comment 3 Mattias Bengtsson 2014-03-02 17:35:04 UTC
Created attachment 270705 [details] [review]
Fix make distcheck

The 'make distcheck' test has been failing since 5d9046b this commit
makes sure that the generated files {path,config}.js are put into
${buildir} instead of ${srcdir} and that they are properly cleaned up.
Comment 4 Jonas Danielsson 2014-03-02 19:10:42 UTC
Review of attachment 270705 [details] [review]:

Looks fine to me, thanks!
Comment 5 Mattias Bengtsson 2014-03-02 19:16:25 UTC
Attachment 270705 [details] pushed as 41dc441 - Fix make distcheck