GNOME Bugzilla – Bug 723580
Add “move titlebar on the screen” logic for client-side titlebars
Last modified: 2021-07-05 13:45:39 UTC
The option “move titlebar on the screen” of the <alt>space menu bugs with headerbars: * it’s always shown (clickable), even if the window is totally displayed; * it does nothing, even if the headerbar is not visible.
The reason it shows up is a simple logic bug in meta_window_titlebar_is_onscreen(): gboolean meta_window_titlebar_is_onscreen (MetaWindow *window) { [...] /* Titlebar can't be offscreen if there is no titlebar... */ if (!window->frame) return FALSE; } The comment would refer to returning FALSE not TRUE. The better long-term fix, though, would be to have some way for a CSD window to indicate the size of the titlebar. (Also needed for cascading.)
Created attachment 271053 [details] [review] Fix meta_window_titlebar_is_onscreen() for titlebar-less windows Here's the trivial fix - if we apply this we should retitle the bug and repurpose it to handle a client-reported titlebar, since it's not *really* making the functionality work, it's just making it not appear at the wrong time. ==== Make the code correspond to the comment - the titlebar can't be offscreen if there's no titlebar.
Review of attachment 271053 [details] [review]: Seems this bug has been around since 2005... sigh.
Comment on attachment 271053 [details] [review] Fix meta_window_titlebar_is_onscreen() for titlebar-less windows Attachment 271053 [details] pushed as 40c15f6 - Fix meta_window_titlebar_is_onscreen() for titlebar-less windows
GNOME is going to shut down bugzilla.gnome.org in favor of gitlab.gnome.org. As part of that, we are mass-closing older open tickets in bugzilla.gnome.org which have not seen updates for a longer time (resources are unfortunately quite limited so not every ticket can get handled). If you can still reproduce the situation described in this ticket in a recent and supported software version, then please follow https://wiki.gnome.org/GettingInTouch/BugReportingGuidelines and create a new ticket at https://gitlab.gnome.org/GNOME/mutter/-/issues/ Thank you for your understanding and your help.