After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723574 - Patch to make DMAP media list hierarchical
Patch to make DMAP media list hierarchical
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: plugins
0.2.x
Other Mac OS
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-04 01:34 UTC by W. Michael Petullo
Modified: 2014-02-07 08:19 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch to modify DMAP plugin so that it provides a hierarchical media list (25.84 KB, patch)
2014-02-04 01:34 UTC, W. Michael Petullo 		none Details | Review
dmap: provide a hierarchical view of media database (25.88 KB, patch)
2014-02-07 08:16 UTC, Juan A. Suarez Romero 		committed Details | Review
dmap: Use #define for constants (2.07 KB, patch)
2014-02-07 08:16 UTC, Juan A. Suarez Romero 		committed Details | Review
dmap: Add missing file in POTFILES.in (700 bytes, patch)
2014-02-07 08:16 UTC, Juan A. Suarez Romero 		committed Details | Review
dmap: Replace g_warning/debug by GRL_WARNING/DEBUG (1.28 KB, patch)
2014-02-07 08:16 UTC, Juan A. Suarez Romero 		committed Details | Review
dmap: Use C comments (6.57 KB, patch)
2014-02-07 08:16 UTC, Juan A. Suarez Romero 		committed Details | Review

Description W. Michael Petullo 2014-02-04 01:34:48 UTC 
Created attachment 268025 [details] [review]
Patch to modify DMAP plugin so that it provides a hierarchical media list

It would be more convenient/consistent if the DMAP plugin imposed some (artificial, with respect to the DMAP protocol itself) structure on the media it finds.

With this patch, the DMAP plugin will present:

  (Albums, Artists) ->
  (Album_1, Album_2, ..., Album_n) or (Artist_1, ...) ->
  (Track_1, Track_2, ..., Track_n)
Comment 1 Juan A. Suarez Romero 2014-02-07 08:16:20 UTC 
Created attachment 268377 [details] [review]
dmap: provide a hierarchical view of media database

https://bugzilla.gnome.org/show_bug.cgi?id=723574

Signed-off-by: W. Michael Petullo <mike@flyn.org>
Comment 2 Juan A. Suarez Romero 2014-02-07 08:16:24 UTC 
Created attachment 268378 [details] [review]
dmap: Use #define for constants
Comment 3 Juan A. Suarez Romero 2014-02-07 08:16:28 UTC 
Created attachment 268379 [details] [review]
dmap: Add missing file in POTFILES.in
Comment 4 Juan A. Suarez Romero 2014-02-07 08:16:32 UTC 
Created attachment 268380 [details] [review]
dmap: Replace g_warning/debug by GRL_WARNING/DEBUG
Comment 5 Juan A. Suarez Romero 2014-02-07 08:16:35 UTC 
Created attachment 268381 [details] [review]
dmap: Use C comments

Do not use C++ comments.
Comment 6 Juan A. Suarez Romero 2014-02-07 08:18:00 UTC 
Attachment 268377 [details] pushed as e254e9b - dmap: provide a hierarchical view of media database
Attachment 268378 [details] pushed as 2137316 - dmap: Use #define for constants
Attachment 268379 [details] pushed as 72502c1 - dmap: Add missing file in POTFILES.in
Attachment 268380 [details] pushed as f03e6f4 - dmap: Replace g_warning/debug by GRL_WARNING/DEBUG
Attachment 268381 [details] pushed as 3277e6e - dmap: Use C comments
Comment 7 Juan A. Suarez Romero 2014-02-07 08:19:35 UTC 
Comment on attachment 268025 [details] [review]
Patch to modify DMAP plugin so that it provides a hierarchical media list

Re-attached