After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723555 - [PATCH] Decode extension names in X11 error handler
[PATCH] Decode extension names in X11 error handler
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: X11
3.11.x
Other All
: Normal enhancement
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-02-03 20:37 UTC by Adam Jackson
Modified: 2014-02-04 01:16 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtk3-decode-error-extension-names.patch (2.32 KB, patch)
2014-02-03 20:37 UTC, Adam Jackson 		accepted-commit_now Details | Review

Description Adam Jackson 2014-02-03 20:37:58 UTC 
Created attachment 267998 [details] [review]
gtk3-decode-error-extension-names.patch

Extensions in X have their major opcodes dynamically assigned at server startup.  Since they vary it would be nice if the error handler told you what the number maps to, otherwise it's hard to use the error message to actually debug the problem.

Attached patch fixes this by looking it up in xlib's cache; we can't use XQueryExtensions since it generates protocol, which you can't do from an error handler.
Comment 1 Matthias Clasen 2014-02-04 01:13:56 UTC 
Review of attachment 267998 [details] [review]:

nice, thanks