After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723548 - Port to GMenuModel
Port to GMenuModel
Status: RESOLVED OBSOLETE
Product: evince
Classification: Core
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-02-03 17:42 UTC by Lars Karlitski
Modified: 2018-05-22 15:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Lars Karlitski 2014-02-03 17:42:02 UTC 
I've ported evince's view and action menus to GMenuModel in wip/gmenu. It also adds "open" and "about" actions to the app menu.

That branch also contains a patch which shows a traditional menubar on platforms that prefer it.
Comment 1 Germán Poo-Caamaño 2014-02-03 19:15:07 UTC 
Hi,

May you rebase it against master?
Comment 2 Lars Karlitski 2014-02-04 10:25:48 UTC 
(In reply to comment #1)
> May you rebase it against master?

Sure, done.
Comment 3 Christian Persch 2014-02-20 21:04:23 UTC 
I think this patch series does too much at once. Please split adding the legacy menubars off into a separate bug. And adding the about item to the app menu has been discussed in bug 674937 and rejected; let's not sneak this in with this unrelated bug at least; in any case changing the app menu deserves its own bug, too.

I've already said I oppose moving the actions from window to app, so I oppose that patch in the series.

I'll probably get to doing a full review of the port-to-gmenu patch at the weekend.
Comment 4 Carlos Garcia Campos 2014-02-23 12:08:30 UTC 
It would also help if patches are attached to bugzilla, so that we can use the splinter for review.
Comment 5 GNOME Infrastructure Team 2018-05-22 15:29:55 UTC 
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/evince/issues/433.