After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723491 - Editing PDF, LibreOffice documents is broken
Editing PDF, LibreOffice documents is broken
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.10.x
Other All
: Normal major
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-02-02 23:14 UTC by Michael Catanzaro
Modified: 2014-03-06 10:34 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
screenshot (10.39 KB, image/png)
2014-02-02 23:14 UTC, Michael Catanzaro 		  Details
application: Do not unconditionally enable edit-current in PREVIEW (1.17 KB, patch)
2014-03-05 16:26 UTC, Debarshi Ray 		committed Details | Review
documents: Let DocCommon children indicate whether they support editing (2.28 KB, patch)
2014-03-05 16:27 UTC, Debarshi Ray 		committed Details | Review

Description Michael Catanzaro 2014-02-02 23:14:46 UTC 
Created attachment 267875 [details]
screenshot

Documents has an edit mode that allows me to edit Google docs or LibreOffice documents.  But I can still choose Edit for PDF documents, which won't work. I enter a screen that is pure white. If I click on the View button to return to the original view, the text on the button becomes insensitive and the text turns gray.
Comment 1 Michael Catanzaro 2014-02-02 23:34:53 UTC 
(In reply to comment #0)
> Created an attachment (id=267875) [details]
> screenshot
> 
> Documents has an edit mode that allows me to edit Google docs or LibreOffice
> documents.

Nope, LibreOffice documents take me to this white screen as well.
Comment 2 Debarshi Ray 2014-03-03 14:28:43 UTC 
Editing currently only works for remote documents by embedding a WebKitWebView inside the application. I think we should make the 'edit' menu item insensitive for local content.
Comment 3 Debarshi Ray 2014-03-05 16:26:57 UTC 
Created attachment 271007 [details] [review]
application: Do not unconditionally enable edit-current in PREVIEW
Comment 4 Debarshi Ray 2014-03-05 16:27:31 UTC 
Created attachment 271008 [details] [review]
documents: Let DocCommon children indicate whether they support editing
Comment 5 Debarshi Ray 2014-03-05 16:55:42 UTC 
I am wondering whether we should move the 'activate' callbacks for edit-current and view-current to Application._actionEntries. I don't see why they need to be scattered in different places.
Comment 6 Cosimo Cecchi 2014-03-05 21:25:14 UTC 
Review of attachment 271007 [details] [review]:

Looks good
Comment 7 Cosimo Cecchi 2014-03-05 21:25:37 UTC 
Review of attachment 271008 [details] [review]:

Sure
Comment 8 Cosimo Cecchi 2014-03-05 21:27:24 UTC 
(In reply to comment #5)
> I am wondering whether we should move the 'activate' callbacks for edit-current
> and view-current to Application._actionEntries. I don't see why they need to be
> scattered in different places.

If it simplifies the logic/code, feel free to open a separate issue for that.
Comment 9 Debarshi Ray 2014-03-06 10:34:04 UTC 
Thanks for the review.