After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723469 - SMART test results: increase column width
SMART test results: increase column width
Status: RESOLVED FIXED
Product: gnome-disk-utility
Classification: Core
Component: general
3.14.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-disk-utility-maint
gnome-disk-utility-maint
Depends on:
Blocks:
 
 
Reported: 2014-02-02 10:48 UTC by Max Mustermann
Modified: 2015-02-24 18:42 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of SMART test results (96.59 KB, image/png)
2014-02-02 10:48 UTC, Max Mustermann
  Details
Make SMART dialog resizable (1.35 KB, patch)
2015-02-24 14:06 UTC, Alexandre Franke
committed Details | Review

Description Max Mustermann 2014-02-02 10:48:23 UTC
Created attachment 267837 [details]
Screenshot of SMART test results

The column widths are not resizable. This makes it hard to read the SMART attribute names at a glance (without needing to hover with the mouse over each row), see attachment. 
It would be helpful to have the columns either with the proper width from the beginning or make them resizable (with a single or double click on the column separator). Thank you in advance.
Comment 1 Alexandre Franke 2015-02-11 13:33:25 UTC
Also the dialog cannot be resized so even if your screen is wide enough, you end up with an unreadable window.
Comment 2 Alexandre Franke 2015-02-24 14:06:10 UTC
Created attachment 297765 [details] [review]
Make SMART dialog resizable

Data often spill out the ridiculously small window
Comment 3 Matthias Clasen 2015-02-24 14:33:32 UTC
Does the window come up with a reasonable size after this change ?
Other than that, looks ok to me.
Comment 4 Alexandre Franke 2015-02-24 14:51:47 UTC
This doesn't seem to change the default size.
Comment 5 David King 2015-02-24 15:21:43 UTC
Review of attachment 297765 [details] [review]:

Making the individual columns resizable (with the "resizable" property on GtkTreeViewColumn) is also an option, but this seems fine.
Comment 6 Alexandre Franke 2015-02-24 15:30:27 UTC
(In reply to David King from comment #5)
> Review of attachment 297765 [details] [review] [review]:
> 
> Making the individual columns resizable (with the "resizable" property on
> GtkTreeViewColumn) is also an option, but this seems fine.

The issue with that option is that the window still be too narrow to display everything. Also it's ridiculous to constraint the window for no reason, especially when on some modern displays it barely occupies half the width.

Do you think we should do both though?
Comment 7 David King 2015-02-24 15:57:37 UTC
No, the patch is fine.
Comment 8 Alexandre Franke 2015-02-24 18:42:30 UTC
Attachment 297765 [details] pushed as 7368cf6 - Make SMART dialog resizable