After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723461 - Build fails in babl-gen-test-pixels when srandom is missing
Build fails in babl-gen-test-pixels when srandom is missing
Status: RESOLVED FIXED
Product: GEGL
Classification: Other
Component: babl
git master
Other Windows
: Normal normal
: ---
Assigned To: Default Gegl Component Owner
Default Gegl Component Owner
Depends on:
Blocks:
 
 
Reported: 2014-02-02 04:26 UTC by Daniel Sabo
Modified: 2014-02-05 10:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Disable babl-gen-test-pixels when random is missing (1.27 KB, patch)
2014-02-02 04:27 UTC, Daniel Sabo
none Details | Review
tests: Use rand when random is unavailable (717 bytes, patch)
2014-02-02 07:16 UTC, Daniel Sabo
none Details | Review

Description Daniel Sabo 2014-02-02 04:26:17 UTC
The purpose of babl-gen-test-pixels was to make execution not depend on srandom/random, but it also removed the fallback to srand needed to compile on Windows.
Comment 1 Daniel Sabo 2014-02-02 04:27:25 UTC
Created attachment 267825 [details] [review]
Disable babl-gen-test-pixels when random is missing
Comment 2 Daniel Sabo 2014-02-02 07:16:08 UTC
Created attachment 267829 [details] [review]
tests: Use rand when random is unavailable

And another patch to take care of babl_fish_path_fitness.
Comment 3 Daniel Sabo 2014-02-05 10:02:28 UTC
commit c1f075f22c70de54c2b04ca5df008a5e406d3ca9
Author: Daniel Sabo <DanielSabo@gmail.com>
Date:   Sat Feb 1 23:13:28 2014 -0800

    tests: Use rand when random is unavailable

 tests/babl_fish_path_fitness.c | 5 +++++
 1 file changed, 5 insertions(+)

commit 20b208085ffc6124eb4c2c5b1a6ddf95927ef6be
Author: Daniel Sabo <DanielSabo@gmail.com>
Date:   Sat Feb 1 20:22:49 2014 -0800

    Disable babl-gen-test-pixels when random is missing
    
    babl-gen-test-pixels is only needed to regenerate the source
    pixels and doesn't need to be run as part of the normal build
    process.

 configure.ac      | 7 +++++++
 tools/Makefile.am | 2 ++
 2 files changed, 9 insertions(+)