After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723377 - Add alternate zoom shortcuts
Add alternate zoom shortcuts
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: general
3.11.x (obsolete)
Other Linux
: Normal minor
: ---
Assigned To: Evolution Shell Maintainers Team
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2014-01-31 16:00 UTC by Hans
Modified: 2014-02-02 17:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Screenshot of Evo 3.6.4 Menu->View->Zoom (145.67 KB, image/png)
2014-02-02 06:40 UTC, Hans
Details
Screenshot of Evo 3.10.3 Menu->View-Zoom (146.27 KB, image/png)
2014-02-02 06:44 UTC, Hans
Details
My US Keyboard (1.14 MB, image/jpeg)
2014-02-02 15:06 UTC, Hans
Details

Description Hans 2014-01-31 16:00:24 UTC
Since Evo. 3.6.4 the Ctrl+'+' Keyboard shortcut (increase text size) fails. Ctrl+'-' is works OK.

Ctrl+Shift'+' is inconsistent with other applications and confuses users.

The Menu item View->Zoom->'Zoom In   Ctrl++' works as it should work. Maybe the
shortcut is wrongly configured.
Comment 1 André Klapper 2014-01-31 16:17:31 UTC
What is your keyboard layout configuration under GNOME? Screenshot welcome.
Comment 2 Matthew Barnes 2014-01-31 18:02:17 UTC
I already explained this on the list:
https://mail.gnome.org/archives/evolution-list/2014-January/msg00118.html

The zoom in shortcut works fine.  It's Ctrl + the keystroke for '+'.

Least on a U.S. keyboard with a [+ =] key, '+' is Shift + the [+ =] key.  So the shortcut is Ctrl + Shift + [+ =].

Anyway, this stuff is handled at the GDK layer, not in Evolution.
Comment 3 Hans 2014-02-02 06:03:48 UTC
Maybe the text in Menu->View->Zoom->"Zoom In  Ctrl++" should be changed to "Zoom In  Ctrl+Shift+".
Comment 4 Hans 2014-02-02 06:40:05 UTC
Created attachment 267826 [details]
Screenshot of Evo 3.6.4 Menu->View->Zoom
Comment 5 Hans 2014-02-02 06:44:16 UTC
Created attachment 267827 [details]
Screenshot of Evo 3.10.3 Menu->View-Zoom
Comment 6 Hans 2014-02-02 06:51:01 UTC
If this is not a Evolution Bug, please transfer this Bug Report to whoever handles GTK Bugs. I noticed that the same Bug applies to Nautilus and probably other applications.
Comment 7 Hans 2014-02-02 07:05:11 UTC
Sorry, Nautilus Cltr++ works fine
Comment 8 Pete Biggs 2014-02-02 12:08:01 UTC
Evolution uses Ctrl + '+' as the zoom shortcut - on standard keyboards in order to get the '+' sign you have to press <shift>+'='.

Nautilus uses three shortcuts for zoom Ctrl + '+', Ctrl + '=' and Ctrl + 'keypad+'

Perhaps Evolution should just add the extra shortcuts to avoid confusion?


$ grep zoom .config/evolution/accels
; (gtk_accel_path "<Actions>/action-group-standard/mail-zoom-out" "<Primary>minus")
; (gtk_accel_path "<Actions>/action-group-standard/mail-zoom-in" "<Primary>plus")
; (gtk_accel_path "<Actions>/action-group-standard/mail-zoom-100" "<Primary>0")
; (gtk_accel_path "<Actions>/action-group-standard/mail-zoom-menu" "")
; (gtk_accel_path "<Actions>/mail/mail-zoom-menu" "")
; (gtk_accel_path "<Actions>/mail/mail-zoom-out" "<Primary>minus")
; (gtk_accel_path "<Actions>/mail/mail-zoom-100" "<Primary>0")
; (gtk_accel_path "<Actions>/mail/mail-zoom-in" "<Primary>plus")

$ grep Zoom .config/nautilus/accels 
; (gtk_accel_path "<Actions>/ShellActions/ZoomInAccel" "<Primary>equal")
; (gtk_accel_path "<Actions>/ShellActions/Zoom Normal" "<Primary>0")
; (gtk_accel_path "<Actions>/ShellActions/ZoomInAccel2" "<Primary>KP_Add")
; (gtk_accel_path "<Actions>/ShellActions/Zoom Out" "<Primary>minus")
; (gtk_accel_path "<Actions>/ShellActions/Zoom In" "<Primary>plus")
; (gtk_accel_path "<Actions>/ShellActions/ZoomOutAccel" "<Primary>KP_Subtract")
Comment 9 Hans 2014-02-02 15:06:35 UTC
Created attachment 267853 [details]
My US Keyboard
Comment 10 Matthew Barnes 2014-02-02 15:15:21 UTC
(In reply to comment #8)
> Nautilus uses three shortcuts for zoom Ctrl + '+', Ctrl + '=' and Ctrl +
> 'keypad+'
> 
> Perhaps Evolution should just add the extra shortcuts to avoid confusion?

Not a bad idea, since the reporter clearly expects it to be Ctrl + '='.

That assumes, however, all keyboard types have a [+ =] key.  Not sure if that's true or not.  Maybe it's common enough that a few exceptions don't matter.  I'll take a look at how Nautilus does it.
Comment 11 Hans 2014-02-02 15:47:21 UTC
Why don't you use the code from Evolution 3.4.4. and earlier. This was working as expected.
Comment 12 Matthew Barnes 2014-02-02 15:55:24 UTC
The shortcut hasn't changed since 2008:

$ git blame e-mail-reader.c
8e2b445e (Matthew Barnes 2008-12-27 ...)  N_("_Zoom In"),
8e2b445e (Matthew Barnes 2008-12-27 ...)  "<Control>plus",
8e2b445e (Matthew Barnes 2008-12-27 ...)  N_("Increase the text size"),
8e2b445e (Matthew Barnes 2008-12-27 ...)  G_CALLBACK (action_mail_zoom_in_cb) },

and even before that it was still Ctrl + '+'.
Comment 13 Pete Biggs 2014-02-02 16:06:11 UTC
> 
> That assumes, however, all keyboard types have a [+ =] key.  Not sure if that's
> true or not.  Maybe it's common enough that a few exceptions don't matter. 

Most Latin keyboards have the +/= key as do many of the Asian ones, but it's certainly not Universal. See http://en.wikipedia.org/wiki/Keyboard_layout

Nevertheless implementing the Ctrl-+, Ctrl-= and Ctrl-keypad+ will probably cover virtually everything.
Comment 14 Matthew Barnes 2014-02-02 17:05:58 UTC
Fixed for Evolution 3.11.5 and 3.10.4:

https://git.gnome.org/browse/evolution/commit/?id=8924b0bd5ef04c30ed3a43652e70e583407f7b85

https://git.gnome.org/browse/evolution/commit/?h=gnome-3-10&id=c5c5fe0b5b1c8d951508c7b0a421b342d05abdae

Spotted GDK definitions for dedicated Zoom In / Zoom Out keys on some keyboard models, so I added those too.