After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723374 - Check for WritableContainer instance only just before adding reference
Check for WritableContainer instance only just before adding reference
Status: RESOLVED FIXED
Product: rygel
Classification: Applications
Component: librygel-server
git master
Other Linux
: Normal normal
: ---
Assigned To: rygel-maint
rygel-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-31 15:22 UTC by Parthiban Balasubramanian
Modified: 2014-06-14 14:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Check WritableContainer before adding reference. (1.96 KB, patch)
2014-01-31 15:22 UTC, Parthiban Balasubramanian 		none Details | Review
server: Fix order of fetching/adding (1.49 KB, patch)
2014-06-14 14:31 UTC, Jens Georg 		committed Details | Review

Description Parthiban Balasubramanian 2014-01-31 15:22:30 UTC 
Created attachment 267736 [details] [review]
Check WritableContainer before adding reference.

Current logic of fetch_container () in rygel-reference-creator checks for WritableContainer instance way before attempting to add a reference to a container. 

Moved the logic to check for WritableContainer just before trying to add reference to the container.

This fix allows CTT 7.2.16.1 to pass from warning.
Comment 1 Jens Georg 2014-02-01 13:53:59 UTC 
I'm a bit lost, what exact error this is fixing? What are we returning, what does DLNA expect us to return?
Comment 2 Jens Georg 2014-06-14 14:31:32 UTC 
Created attachment 278444 [details] [review]
server: Fix order of fetching/adding

Signed-off-by: Jens Georg <mail@jensge.org>

Other version of the original patch that doesn't create NULL access and
potential criticals
Comment 3 Jens Georg 2014-06-14 14:31:48 UTC 
Attachment 278444 [details] pushed as 7742b82 - server: Fix order of fetching/adding