After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723351 - Non-void function should return a value
Non-void function should return a value
Product: totem
Classification: Core
Component: Movie player
Other All
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on:
Reported: 2014-01-31 10:06 UTC by Ting-Wei Lan
Modified: 2014-01-31 10:56 UTC
See Also:
GNOME target: ---
GNOME version: 3.11/3.12

Fix "Non-void function should return a value" (604 bytes, patch)
2014-01-31 10:06 UTC, Ting-Wei Lan
committed Details | Review

Description Ting-Wei Lan 2014-01-31 10:06:50 UTC
Created attachment 267712 [details] [review]
Fix "Non-void function should return a value"

src/totem-search-entry.c: totem_search_entry_set_selected_id() has a return value, so g_return_if_fail should be replaced by g_return_val_if_fail.
Comment 1 Bastien Nocera 2014-01-31 10:10:22 UTC
Looks good.