GNOME Bugzilla – Bug 723280
Ambigous options in screen sharing dialog
Last modified: 2014-02-18 11:25:55 UTC
* It isn't clear whether "Approve All Connections" automatically approves connections, or whether you have to approve them. * It isn't clear who has to provide the password when "require password" is on. * It isn't clear what will happen if both of the above are switched to off. Downstream bug: https://bugzilla.redhat.com/show_bug.cgi?id=1049911 Mockup: https://raw.github.com/gnome-design-team/gnome-mockups/master/system-settings/sharing/screen-sharing.png
Created attachment 269223 [details] [review] sharing: address ambiguity in the screen sharing dialog This patch makes the changes to address the ambiguity, but it doesn't add the generate password or "Copy" button in the mockup, as these would be new features. The panel already ensures that it is not possible to set a blank password and will ensure the option is reverted if the password is left blank.
Review of attachment 269223 [details] [review]: Looks good
Created attachment 269373 [details] screenshot Looks really good to me too. The one thing I would like to see is a narrower window. Another smaller issue - it would be good to add a bit of vertical padding above the screen sharing switch.
Pushed this, the new features should go in another bug. Attachment 269223 [details] pushed as ab4a523 - sharing: address ambiguity in the screen sharing dialog
I've reported the outstanding layout issues as bug 724629.