After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723269 - matroskamux: used uid list grows forever
matroskamux: used uid list grows forever
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other All
: Normal normal
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-30 09:07 UTC by Per Johansson
Modified: 2014-01-30 15:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Suggested fix. (3.82 KB, patch)
2014-01-30 09:07 UTC, Per Johansson 		committed Details | Review

Description Per Johansson 2014-01-30 09:07:35 UTC 
Created attachment 267613 [details] [review]
Suggested fix.

The matroska muxer stores all used track uid in a global array that is never cleared. This means that for processes that are living for a long time this adds up to quite a lot of memory.

The provided patch moves the list into the class so that uniqueness can still be guaranteed within the file, but memory consumption is limited.
Comment 1 Thiago Sousa Santos 2014-01-30 15:07:14 UTC 
thanks for the patch!

commit 46bc1677a4fa8c640130e58b052376a16cebfdbb
Author: Per x Johansson <perxjoh@axis.com>
Date:   Thu Jan 30 09:43:50 2014 +0100

    matroskamux: Fix constantly growing used uid list
    
    Moves the used uid list to the class to avoid having it grow forever.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=723269