After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723242 - Typo in back key detection
Typo in back key detection
Status: RESOLVED FIXED
Product: gnome-documents
Classification: Core
Component: general
3.10.x
Other All
: Normal normal
: ---
Assigned To: GNOME documents maintainer(s)
GNOME documents maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-01-29 15:29 UTC by Debarshi Ray
Modified: 2014-01-29 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
mainWindow: Fix typo in back key detection for RTL locales (1.08 KB, patch)
2014-01-29 15:33 UTC, Debarshi Ray 		committed Details | Review

Description Debarshi Ray 2014-01-29 15:29:49 UTC 
The logic should be:
  ((is_alt && ((left in LTR) || (right in RTL))) || is_back)

Currently it is:
  ((is_alt && (left in LTR) || (right in RTL)) || is_back)

... which means that in RTL locales we do not correctly detect Alt+right for going back.
Comment 1 Debarshi Ray 2014-01-29 15:33:24 UTC 
Created attachment 267539 [details] [review]
mainWindow: Fix typo in back key detection for RTL locales
Comment 2 Cosimo Cecchi 2014-01-29 16:47:52 UTC 
Review of attachment 267539 [details] [review]:

Looks good to me
Comment 3 Debarshi Ray 2014-01-29 16:51:59 UTC 
Comment on attachment 267539 [details] [review]
mainWindow: Fix typo in back key detection for RTL locales

Thanks for the review!