GNOME Bugzilla – Bug 723238
popup windows should respect the window properties
Last modified: 2014-02-05 17:14:09 UTC
When a popup window is created (window.open()) the window features (WebKitWindowProperties) should be honored.
Created attachment 267525 [details] [review] Remove chrome and popup parameters from ephy_shell_new_tab_full
Created attachment 267526 [details] [review] Move the window geometry handling from EphyEmbed to EphyWindow
Created attachment 267527 [details] [review] Remove show-toolbars setting
Created attachment 267528 [details] [review] Make sure the toolbar is always visible
Created attachment 267529 [details] [review] Move the UI chrome handling to EphyWindow
Created attachment 267530 [details] [review] popup windows should respect the window properties
Created attachment 267531 [details] [review] Make the location entry non-editable for popups
Review of attachment 267525 [details] [review]: Makes sense.
*** Bug 720601 has been marked as a duplicate of this bug. ***
Review of attachment 267526 [details] [review]: OK
Review of attachment 267527 [details] [review]: Fine by me.
Review of attachment 267528 [details] [review]: You mean always active, right?
(In reply to comment #12) > Review of attachment 267528 [details] [review]: > > You mean always active, right? I mean always visible, with the toolbar hidden there's no chrome in the window, so it's not obvious how to close the window, and I don't think it's even possible to move it.
Comment on attachment 267528 [details] [review] Make sure the toolbar is always visible I see. Just wondering whether the patch should be merged with the previous one, but I think it looks fine.
Review of attachment 267529 [details] [review]: I guess this is good.
Review of attachment 267530 [details] [review]: OK
Review of attachment 267531 [details] [review]: OK