After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723212 - Use headerbar in GtkAssistant
Use headerbar in GtkAssistant
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-01-29 03:59 UTC by William Jon McCann
Modified: 2014-01-30 01:57 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
assistant: add ability to use header bar (9.89 KB, patch)
2014-01-29 03:59 UTC, William Jon McCann 		committed Details | Review
assistant: make button labels match mockups (1.89 KB, patch)
2014-01-29 03:59 UTC, William Jon McCann 		committed Details | Review
tests: fix button underline in testassistant (915 bytes, patch)
2014-01-29 04:00 UTC, William Jon McCann 		committed Details | Review
assistant: set window title with page title (847 bytes, patch)
2014-01-29 04:00 UTC, William Jon McCann 		committed Details | Review
assistant: add text-button style class (3.37 KB, patch)
2014-01-29 04:00 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2014-01-29 03:59:45 UTC 
Add headerbars to GtkAssistant as originally intended. Do so in the same
way as for GtkDialog and honor the same setting.
Comment 1 William Jon McCann 2014-01-29 03:59:47 UTC 
Created attachment 267472 [details] [review]
assistant: add ability to use header bar
Comment 2 William Jon McCann 2014-01-29 03:59:57 UTC 
Created attachment 267473 [details] [review]
assistant: make button labels match mockups
Comment 3 William Jon McCann 2014-01-29 04:00:00 UTC 
Created attachment 267474 [details] [review]
tests: fix button underline in testassistant
Comment 4 William Jon McCann 2014-01-29 04:00:04 UTC 
Created attachment 267475 [details] [review]
assistant: set window title with page title

This will set the headerbar title when necessary
Comment 5 William Jon McCann 2014-01-29 04:00:08 UTC 
Created attachment 267476 [details] [review]
assistant: add text-button style class
Comment 6 Matthias Clasen 2014-01-29 22:35:46 UTC 
Review of attachment 267472 [details] [review]:

ok
Comment 7 Matthias Clasen 2014-01-29 22:36:23 UTC 
Review of attachment 267473 [details] [review]:

ok
Comment 8 Matthias Clasen 2014-01-29 22:36:38 UTC 
Review of attachment 267474 [details] [review]:

sure
Comment 9 Matthias Clasen 2014-01-29 22:38:29 UTC 
Review of attachment 267475 [details] [review]:

ok
Comment 10 Matthias Clasen 2014-01-29 22:38:47 UTC 
Review of attachment 267476 [details] [review]:

sure
Comment 11 William Jon McCann 2014-01-30 01:56:54 UTC 
Attachment 267472 [details] pushed as ec10bbd - assistant: add ability to use header bar
Attachment 267473 [details] pushed as 8ea33c2 - assistant: make button labels match mockups
Attachment 267474 [details] pushed as b69ac96 - tests: fix button underline in testassistant
Attachment 267475 [details] pushed as 9698d73 - assistant: set window title with page title
Attachment 267476 [details] pushed as 6a285da - assistant: add text-button style class