After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723197 - shell-app: Don't crash when trying to dispose
shell-app: Don't crash when trying to dispose
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-28 21:49 UTC by Jasper St. Pierre (not reading bugmail)
Modified: 2014-01-29 19:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
shell-app: Don't crash when trying to dispose (1.14 KB, patch)
2014-01-28 21:49 UTC, Jasper St. Pierre (not reading bugmail) 		committed Details | Review

Description Jasper St. Pierre (not reading bugmail) 2014-01-28 21:49:06 UTC 
Spotted in the real world by a user on IRC today. I haven't reproduced
this crash myself, and I'm not sure of the situation where a ShellApp
would be disposed when there's no windows left, but let's not crash
here, OK?
Comment 1 Jasper St. Pierre (not reading bugmail) 2014-01-28 21:49:08 UTC 
Created attachment 267447 [details] [review]
shell-app: Don't crash when trying to dispose

If we dispose a ShellApp that has windows left, then we'll crash
when we remove the last window, as that frees and NULLs out
app->running_state.
Comment 2 Andreas Bresser 2014-01-29 12:35:13 UTC 
I am that guy from IRC.

To reproduce the bug you have to use the auto-complete feature in Intellij IDEA in some ActionScript code. When the auto-complete window closes gnome-shell crashes.

I just applied the patch and build a local rpm. My line numbers were others, (1556 instead of 1384) but it works now, I can not reproduce the bug with my patched rpm.
Comment 3 Florian Müllner 2014-01-29 16:05:10 UTC 
Review of attachment 267447 [details] [review]:

LGTM
Comment 4 Jasper St. Pierre (not reading bugmail) 2014-01-29 19:03:01 UTC 
Attachment 267447 [details] pushed as 36c6912 - shell-app: Don't crash when trying to dispose