After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723181 - Use GtkPopover for GtkScaleButton
Use GtkPopover for GtkScaleButton
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
3.11.x
Other Mac OS
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-01-28 18:36 UTC by Bastien Nocera
Modified: 2014-02-03 21:17 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
GtkScaleButton: Use a popover (37.71 KB, patch)
2014-01-30 02:23 UTC, Matthias Clasen 		committed Details | Review
GtkVolumeButton: Remove tooltips (2.23 KB, patch)
2014-01-30 02:32 UTC, Matthias Clasen 		committed Details | Review
how it looks (11.93 KB, image/png)
2014-01-30 02:34 UTC, Matthias Clasen 		  Details
how it looks (12.36 KB, image/png)
2014-01-30 02:34 UTC, Matthias Clasen 		  Details
slight problem in totem: clutter gets in the way (591.08 KB, image/png)
2014-01-30 02:35 UTC, Matthias Clasen 		  Details
totem master popover (10.62 KB, image/png)
2014-01-30 10:12 UTC, Bastien Nocera 		  Details
forcing margins to zero (69.52 KB, image/png)
2014-02-03 20:23 UTC, Matthias Clasen 		  Details

Description Bastien Nocera 2014-01-28 18:36:39 UTC 
Instead of a popup dialog with a the problems it causes.
Comment 1 Matthias Clasen 2014-01-30 02:23:07 UTC 
Created attachment 267601 [details] [review]
GtkScaleButton: Use a popover

This works better than the contortions we're currently doing
with an undecorated dialog, and grabs.
Comment 2 Matthias Clasen 2014-01-30 02:32:06 UTC 
Created attachment 267602 [details] [review]
GtkVolumeButton: Remove tooltips

Showing tooltips on top of a transient popup does not work
out well, and is not really necessary here. At the same time,
remove the unnecessary repetitions of properties. In particular,
setting the label of the buttons here defeats the scale buttons
use of symbolic icons.
Comment 3 Matthias Clasen 2014-01-30 02:34:03 UTC 
Created attachment 267603 [details]
how it looks
Comment 4 Matthias Clasen 2014-01-30 02:34:23 UTC 
Created attachment 267604 [details]
how it looks
Comment 5 Matthias Clasen 2014-01-30 02:35:42 UTC 
Created attachment 267605 [details]
slight problem in totem: clutter gets in the way
Comment 6 Bastien Nocera 2014-01-30 10:08:50 UTC 
Does GtkPopover clear its background to draw the shadow around the "popup"? I'd expect that to cause problems in totem 3.10, but it shouldn't (but does) in 3.12 where the popup is in the clutter-gtk scene as well.
Comment 7 Bastien Nocera 2014-01-30 10:09:54 UTC 
I also get a NULL passed to g_object_ref() when popping out the popover in totem master:

+ Trace 233096

  • #0 g_logv
    at gmessages.c line 1046
  • #1 g_log
    at gmessages.c line 1079
  • #2 g_return_if_fail_warning
  • #3 g_object_ref
    at gobject.c line 3042
  • #4 gtk_popover_apply_modality
    at gtkpopover.c line 249
  • #5 g_closure_invoke
    at gclosure.c line 777
  • #6 signal_emit_unlocked_R
    at gsignal.c line 3486
  • #7 g_signal_emit_valist
    at gsignal.c line 3312
  • #8 g_signal_emit
    at gsignal.c line 3368
  • #9 gtk_widget_map
    at gtkwidget.c line 4589
  • #10 g_closure_invoke
    at gclosure.c line 777
  • #11 signal_emit_unlocked_R
    at gsignal.c line 3486
  • #12 g_signal_emit_valist
    at gsignal.c line 3312
  • #13 g_signal_emit
    at gsignal.c line 3368
  • #14 gtk_widget_show
    at gtkwidget.c line 4397
  • #15 gtk_scale_popup
    at gtkscalebutton.c line 813
  • #16 _g_closure_invoke_va
    at gclosure.c line 840
  • #17 g_signal_emit_valist
    at gsignal.c line 3220
  • #18 g_signal_emit
    at gsignal.c line 3368
  • #19 gtk_button_do_release
    at gtkbutton.c line 1987
  • #20 gtk_real_button_released
    at gtkbutton.c line 2105
  • #21 _g_closure_invoke_va
    at gclosure.c line 840
  • #22 g_signal_emit_valist
    at gsignal.c line 3220
  • #23 g_signal_emit
    at gsignal.c line 3368
  • #24 gtk_button_button_release
    at gtkbutton.c line 1942
  • #25 _gtk_marshal_BOOLEAN__BOXEDv
    at gtkmarshalers.c line 130
  • #26 _g_closure_invoke_va
    at gclosure.c line 840
  • #27 g_signal_emit_valist
    at gsignal.c line 3220
  • #28 g_signal_emit
    at gsignal.c line 3368
  • #29 gtk_widget_event_internal
    at gtkwidget.c line 7228
  • #30 gtk_widget_event
    at gtkwidget.c line 6890
  • #31 propagate_event_up
    at gtkmain.c line 2434
  • #32 propagate_event
    at gtkmain.c line 2542
  • #33 gtk_main_do_event
    at gtkmain.c line 1757
  • #34 gdk_event_source_dispatch
    at gdkeventsource.c line 364
  • #35 g_main_dispatch
    at gmain.c line 3073
  • #36 g_main_context_dispatch
    at gmain.c line 3648
  • #37 g_main_context_iterate
    at gmain.c line 3719
  • #38 g_main_context_iteration
    at gmain.c line 3780
  • #39 g_application_run
    at gapplication.c line 1695
  • #40 main
    at totem.c line 277 






Comment 8


Bastien Nocera





          2014-01-30 10:12:11 UTC
        



Created attachment 267616 [details]
totem master popover






Comment 9


Matthias Clasen





          2014-01-30 13:14:09 UTC
        



(In reply to comment #7)
> I also get a NULL passed to g_object_ref() when popping out the popover in
> totem master:
> 

Should be fixed






Comment 10


Matthias Clasen





          2014-02-03 20:23:07 UTC
        



Created attachment 267997 [details]
forcing margins to zero

Here is how it looks if I force the css margin, padding and border-radius to all be 0.

If totem could do that in the short term, as a workaround. That would let us move ahead with this change






Comment 11


Matthias Clasen





          2014-02-03 20:43:47 UTC
        



Attachment 267601 [details] pushed as c46b1c2 - GtkScaleButton: Use a popover
Attachment 267602 [details] pushed as f058b40 - GtkVolumeButton: Remove tooltips






Comment 12


Matthias Clasen





          2014-02-03 20:55:34 UTC
        



bug 723556 has an untested workaround patch for totem.






Comment 13


Bastien Nocera





          2014-02-03 21:17:37 UTC
        



(In reply to comment #10)
> Created an attachment (id=267997) [details]
> forcing margins to zero
> 
> Here is how it looks if I force the css margin, padding and border-radius to
> all be 0.
> 
> If totem could do that in the short term, as a workaround. That would let us
> move ahead with this change

I'm fine with that. I'll follow up on bug 723556 if needed, thanks!