GNOME Bugzilla – Bug 723176
omx: Examples need to be ported to 1.0
Last modified: 2014-07-23 08:24:58 UTC
Commit c10031f371e5e26075b7ae79e9984c36d68c4231 introduced the examples directory to gst-omx, but the examples are not ported to 1.x so they are disabled. They are disabled like this: # if BUILD_EXAMPLES # SUBDIRS += examples # endif But then in the configure file there's: AC_CONFIG_FILE( ... examples/Makefile examples/egl/Makefile ) So make dist generates a tarball without the examples directory, but then the directory is needed when compiling the tarball.
Created attachment 267419 [details] [review] configure: don't generate Makefiles for the examples directory The examples directory is ignored in Makefile.am and so it's not included in tarballs created with make dist. This made configure fail as it tried to generate make files in that non-existing directory. See c10031f371e5e26075b7ae79e9984c36d68c4231 for more details on the introduction of the examples directory.
Created attachment 267420 [details] [review] configure: don't generate Makefiles for the examples directory The examples directory is ignored in Makefile.am and so it's not included in tarballs created with make dist. This made configure fail as it tried to generate make files in that non-existing directory. See c10031f371e5e26075b7ae79e9984c36d68c4231 for more details on the introduction of the examples directory.
ok we thought that the example was not supposed to work. So I'm going to check that and fix if needed. Also I'll ensure it still work with https://bugzilla.gnome.org/show_bug.cgi?id=722686 changes.
The examples in master does work in 1.x. The SUBDIRS commented block just was missed to be enabled when it was ported. I've also pushed in master the changes to avoid clashing names with the recent move of EGLImagePol to gst egl library. Then I think that this bug could be clossed.
Yep, I can confirm that compiling from the tarball generated with make dist now works. Thanks!