After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723157 - Merge GtkFileChooserWidget and GtkFileChooserDefault
Merge GtkFileChooserWidget and GtkFileChooserDefault
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
Federico Mena Quintero
Depends on:
Blocks:
 
 
Reported: 2014-01-28 10:57 UTC by William Jon McCann
Modified: 2014-02-04 20:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Merge GtkFileChooserWidget and GtkFileChooserDefault (483.62 KB, patch)
2014-01-28 10:57 UTC, William Jon McCann 		committed Details | Review
docs: add docs for GtkFileChooserWidget signals (11.27 KB, patch)
2014-01-28 10:57 UTC, William Jon McCann 		committed Details | Review

Description William Jon McCann 2014-01-28 10:57:29 UTC 
It seems that alternate implementations of GtkFileChooserWidget
    never materialized. The split between GtkFileChooserWidget and
    GtkFileChooserDefault is awkward. The immediate problem is that
    it makes it difficult to document the keybinding signals. So it
    makes sense to drop the abstraction and just have one thing.
Comment 1 William Jon McCann 2014-01-28 10:57:32 UTC 
Created attachment 267390 [details] [review]
Merge GtkFileChooserWidget and GtkFileChooserDefault

It seems that alternate implementations of GtkFileChooserWidget
never materialized. The split between GtkFileChooserWidget and
GtkFileChooserDefault is awkward. The immediate problem is that
it makes it difficult to document the keybinding signals. So it
makes sense to drop the abstraction and just have one thing.
Comment 2 William Jon McCann 2014-01-28 10:57:42 UTC 
Created attachment 267391 [details] [review]
docs: add docs for GtkFileChooserWidget signals
Comment 3 Matthias Clasen 2014-01-29 03:04:01 UTC 
Review of attachment 267390 [details] [review]:

looks ok and works fine in my testing. gedit's embedded filechooser works as before, and make check passes too.
Comment 4 Matthias Clasen 2014-01-29 03:04:42 UTC 
Review of attachment 267391 [details] [review]:

makes sense to bring the keybinding docs here in line with what we do e.g. in GtkTextView
Comment 5 William Jon McCann 2014-01-29 04:11:02 UTC 
Attachment 267390 [details] pushed as d87ea47 - Merge GtkFileChooserWidget and GtkFileChooserDefault
Attachment 267391 [details] pushed as b4d4e08 - docs: add docs for GtkFileChooserWidget signals
Comment 6 Federico Mena Quintero 2014-02-04 20:14:51 UTC 
Thanks for doing this!  It's the kind of navel lint that just needed removing.