GNOME Bugzilla – Bug 723124
Wrap GtkActionBar
Last modified: 2014-04-07 15:24:42 UTC
Created attachment 267349 [details] [review] GtkActionBar wrapper I've a working example, but I didn't generated the corresponding patch to gtkmm-documentation. I guess this is not strictly correct: I've generated this patch from HEAD, the exact same point I generated the patch for GtkPopover from. I presume these two patches will therefore conflict a little bit :(
That looks fine. Thanks. Please push it if you have write access.
Sorry, I don't have write access. Please, let this bug report open, as I can post here an example for the book.
Pushed to master. Thanks. We should probably get you direct git write access soon.
Perfect. Thank you.
Created attachment 267674 [details] [review] Gtk::ActionBar example
Created attachment 273692 [details] [review] patch: Use fallback for symbolic icons Suggested changes to examples/book/actionbar/examplewindow.cc examples/book/headerbar/examplewindow.cc examples/book/popover/examplewindow.cc examples/book/searchbar/examplewindow.cc if (Gtk::Image* image = dynamic_cast<Gtk::Image*>(m_prev_button.get_image())) image->property_use_fallback() = true; is ugly. GtkImage has no get/set methods corresponding to the use-fallback property. Perhaps Gtk::Button::set_image_from_icon_name() should have had a 'bool use_fallback' argument.
Comment on attachment 273692 [details] [review] patch: Use fallback for symbolic icons It seems fine to me. Feel free to add a bool to that method. I trust your judgement.
Although I have no idea what use-fallback means there. The GtkImage documentation doesn't explain it.
I have pushed a gtkmm patch that adds void Button::set_image_from_icon_name(const Glib::ustring& icon_name, IconSize size, bool use_fallback), https://git.gnome.org/browse/gtkmm/commit/?id=a8fb2b77aa0530faeedfce721f1782c7bdfcbc44 and a gtkmm-documentation patch where this new method overload is used, https://git.gnome.org/browse/gtkmm-documentation/commit/?id=12959d5c02ef1d1e7bd552078b87c3db7d7787fc Now some icons are shown even if you have selected an icon theme that lacks *-symbolic named icons.