After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723110 - The margin in the toolbar is wrong in RTL
The margin in the toolbar is wrong in RTL
Status: RESOLVED FIXED
Product: evince
Classification: Core
Component: general
3.11.x
Other Mac OS
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-27 16:03 UTC by Yosef Or Boczko
Modified: 2014-01-28 13:59 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
toolbar: Fix the margin in RTL (3.31 KB, patch)
2014-01-27 16:03 UTC, Yosef Or Boczko 		needs-work Details | Review
toolbar: Fix the margin in RTL (4.03 KB, patch)
2014-01-27 18:44 UTC, Yosef Or Boczko 		committed Details | Review

Description Yosef Or Boczko 2014-01-27 16:03:33 UTC 
See the patch.
Comment 1 Yosef Or Boczko 2014-01-27 16:03:57 UTC 
Created attachment 267320 [details] [review]
toolbar: Fix the margin in RTL
Comment 2 Carlos Garcia Campos 2014-01-27 18:38:01 UTC 
Review of attachment 267320 [details] [review]:

hmm, could you please use #if GTK_CHECK_VERSION instead of bumping the GTK+ requirements? To avoid too many ifdefs you could add a helper function with a single ifdef inside. Thanks.
Comment 3 Yosef Or Boczko 2014-01-27 18:44:03 UTC 
Created attachment 267334 [details] [review]
toolbar: Fix the margin in RTL

Well, this is more an option.
Comment 4 Carlos Garcia Campos 2014-01-28 13:57:01 UTC 
Review of attachment 267334 [details] [review]:

Excellent!
Comment 5 Yosef Or Boczko 2014-01-28 13:58:42 UTC 
Review of attachment 267334 [details] [review]:

Pushed as c858776 - toolbar: Fix the margin in RTL