After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 723082 - 'trychekout' gets confused on consecutive errors
'trychekout' gets confused on consecutive errors
Status: RESOLVED FIXED
Product: jhbuild
Classification: Infrastructure
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Jhbuild maintainers
Jhbuild QA
Depends on:
Blocks:
 
 
Reported: 2014-01-27 10:12 UTC by Emanuele Aina
Modified: 2014-01-29 11:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
terminal: Clean trycheckout status when picking up a new module (1.28 KB, patch)
2014-01-27 10:12 UTC, Emanuele Aina 		committed Details | Review

Description Emanuele Aina 2014-01-27 10:12:08 UTC 
Even with 'trychekout' enabled, if a module fails jhbuild would directly jump
to the interactive prompt if the previous one failed too.

This is caused by the fact that the last tried action is not properly reset
when picking up a new module, so if jhbuild already tried to force_checkout the
previos module it would run out of options for the current one.

The attached patch resets self.triedcheckout on start_module().
Comment 1 Emanuele Aina 2014-01-27 10:12:11 UTC 
Created attachment 267281 [details] [review]
terminal: Clean trycheckout status when picking up a new module

If two consecutive modules were to fail with trycheckout enabled,
jhbuild would get quite confused as the last tried recovery phase didn't
get reset properly.

This would cause jhbuild to go straight to eg. the force_checkout phase
if the previous module built by forcing the configure phase, or bail out
completely if the previous module failed.
Comment 2 Frederic Peters 2014-01-29 11:03:39 UTC 
Thanks.