After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722873 - Selection's start coordinate is off by widget padding
Selection's start coordinate is off by widget padding
Status: RESOLVED FIXED
Product: vte
Classification: Core
Component: general
0.35.x
Other Linux
: Normal normal
: ---
Assigned To: VTE Maintainers
VTE Maintainers
[fixed-0-36][needed-next][commit:3cf7...
Depends on:
Blocks:
 
 
Reported: 2014-01-24 00:38 UTC by Egmont Koblinger
Modified: 2014-04-06 18:27 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix part 1 (734 bytes, patch)
2014-01-24 00:55 UTC, Egmont Koblinger
committed Details | Review

Description Egmont Koblinger 2014-01-24 00:38:59 UTC
~/.config/gtk-3.0/gtk.css:

VteTerminal {
    -VteTerminal-inner-border: 100;          
}

Select by mouse. Notice the start position is off by 100 pixels. (The end position is correct.)
Comment 1 Egmont Koblinger 2014-01-24 00:44:34 UTC
Also, the start coordinate is not confined to be inside the visible area (as it is done in from vte_terminal_extend_selection() for the end point). It's important for the rewrap code that it's confined. (See bug 722635.)
Comment 2 Egmont Koblinger 2014-01-24 00:55:00 UTC
Created attachment 267090 [details] [review]
Fix part 1

Fix for the offset. Actually the padding was substracted twice.

I'm yet to confine the coordinates.
Comment 3 Egmont Koblinger 2014-02-12 21:12:37 UTC
Marking as fixed in vte-0-36 (keeping open for vte-next). The issue mentioned in comment 1 really belongs to the other bug.