After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722872 - Some fixed for RTL
Some fixed for RTL
Status: RESOLVED FIXED
Product: gnome-sound-recorder
Classification: Other
Component: General
3.11.x
Other Mac OS
: Normal normal
: ---
Assigned To: gnome-sound-recorder maintainer(s)
gnome-sound-recorder maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-01-24 00:32 UTC by Yosef Or Boczko
Modified: 2014-01-27 23:54 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Fix the margin in the toolbar in RTL (2.67 KB, patch)
2014-01-24 00:34 UTC, Yosef Or Boczko
committed Details | Review
Fix the start icon in the toolbar in RTL (1.17 KB, patch)
2014-01-24 00:34 UTC, Yosef Or Boczko
committed Details | Review

Description Yosef Or Boczko 2014-01-24 00:32:57 UTC
See the patches.
Comment 1 Yosef Or Boczko 2014-01-24 00:34:12 UTC
Created attachment 267087 [details] [review]
Fix the margin in the toolbar in RTL
Comment 2 Yosef Or Boczko 2014-01-24 00:34:26 UTC
Created attachment 267088 [details] [review]
Fix the start icon in the toolbar in RTL
Comment 3 Yosef Or Boczko 2014-01-24 00:36:25 UTC
(In reply to comment #1)
> Created an attachment (id=267087) [details] [review]
> Fix the margin in the toolbar in RTL

Btw, if we goes with GTK+ 3.12, we can just use margin-start
and margin-end. I don't know why, but it isn't work for me now
(maybe gjs bug, I don't know, but I have gjs and gtk+ from git master).
Comment 4 Yosef Or Boczko 2014-01-24 03:11:01 UTC
Review of attachment 267087 [details] [review]:

Pushed as a99aa79 - Fix the margin in the toolbar in RTL
Comment 5 Meg Ford 2014-01-24 03:19:40 UTC
(In reply to comment #2)
> Created an attachment (id=267088) [details] [review]
> Fix the start icon in the toolbar in RTL

I'll take a look at this one tomorrow. I have some homework. Thanks for again for the patches!
Comment 6 Yosef Or Boczko 2014-01-27 22:58:22 UTC
(In reply to comment #5)
> (In reply to comment #2)
> > Created an attachment (id=267088) [details] [review] [details] [review]
> > Fix the start icon in the toolbar in RTL
> 
> I'll take a look at this one tomorrow. I have some homework. Thanks for again
> for the patches!

Ping?
Comment 7 Meg Ford 2014-01-27 23:48:13 UTC
Review of attachment 267088 [details] [review]:

pushed as a5767ac Fix the start icon in the toolbar in RTL