GNOME Bugzilla – Bug 722867
Some fixes to the about dialog
Last modified: 2014-01-27 23:58:02 UTC
See the patches.
Created attachment 267082 [details] [review] Add a logo to the about dialog
Created attachment 267083 [details] [review] Fix the about dialog when headerbar is used
(In reply to comment #1) > Created an attachment (id=267082) [details] [review] > Add a logo to the about dialog The icon I'm using for the app now is actually just a placeholder, which is why this hasn't been added. Thanks for the reminder! When the application icon is completed (I was just discussing this today with the designer who is working on it) then I'll fix the issue or ask you for an updated patch :)
(In reply to comment #3) > (In reply to comment #1) > > Created an attachment (id=267082) [details] [review] [details] [review] > > Add a logo to the about dialog > > The icon I'm using for the app now is actually just a placeholder, which is why > this hasn't been added. Thanks for the reminder! When the application icon is > completed (I was just discussing this today with the designer who is working on > it) then I'll fix the issue or ask you for an updated patch :) Oh, you right, snwh still work around the icon (https://github.com/gnome-design-team/gnome-icons/commits/master). Btw, I think the current icon is also look very good.
(In reply to comment #2) > Created an attachment (id=267083) [details] [review] > Fix the about dialog when headerbar is used The headerbar in Gtk.AboutDialog recently committed to Gtk+ master, wasn't it? I need to build the most recent Gtk in JhBuild, so I'll test the patches that rely on it this weekend. Thanks for all this! Amazing work and super fast, too :)
(In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #1) > > > Created an attachment (id=267082) [details] [review] [details] [review] [details] [review] > > > Add a logo to the about dialog > > > > The icon I'm using for the app now is actually just a placeholder, which is why > > this hasn't been added. Thanks for the reminder! When the application icon is > > completed (I was just discussing this today with the designer who is working on > > it) then I'll fix the issue or ask you for an updated patch :) > > Oh, you right, snwh still work around the icon > (https://github.com/gnome-design-team/gnome-icons/commits/master). > Btw, I think the current icon is also look very good. :) I committed your patch here: https://git.gnome.org/browse/gnome-sound-recorder/commit/?id=73e4426ebd1c2ce151668fe991885c85ecafe02d
Review of attachment 267082 [details] [review]: Pushed as 73e4426 - Add a logo to the about dialog
(In reply to comment #6) > (In reply to comment #4) > > (In reply to comment #3) > > > (In reply to comment #1) > > > > Created an attachment (id=267082) [details] [review] [details] [review] [details] [review] [details] [review] > > > > Add a logo to the about dialog > > > > > > The icon I'm using for the app now is actually just a placeholder, which is why > > > this hasn't been added. Thanks for the reminder! When the application icon is > > > completed (I was just discussing this today with the designer who is working on > > > it) then I'll fix the issue or ask you for an updated patch :) > > > > Oh, you right, snwh still work around the icon > > (https://github.com/gnome-design-team/gnome-icons/commits/master). > > Btw, I think the current icon is also look very good. > > :) I committed your patch here: > https://git.gnome.org/browse/gnome-sound-recorder/commit/?id=73e4426ebd1c2ce151668fe991885c85ecafe02d Thanks, it realy hard to me to push just one patch from 8 patches :-)
Oops, my bad.
(In reply to comment #5) > (In reply to comment #2) > > Created an attachment (id=267083) [details] [review] [details] [review] > > Fix the about dialog when headerbar is used > > > The headerbar in Gtk.AboutDialog recently committed to Gtk+ master, wasn't it? > I need to build the most recent Gtk in JhBuild, so I'll test the patches that > rely on it this weekend. Thanks for all this! Amazing work and super fast, too > :) This right. I can to say I tested this patch with gtk+ from git master.
(In reply to comment #10) > (In reply to comment #5) > > (In reply to comment #2) > > > Created an attachment (id=267083) [details] [review] [details] [review] [details] [review] > > > Fix the about dialog when headerbar is used > > > > > > The headerbar in Gtk.AboutDialog recently committed to Gtk+ master, wasn't it? > > I need to build the most recent Gtk in JhBuild, so I'll test the patches that > > rely on it this weekend. Thanks for all this! Amazing work and super fast, too > > :) > > This right. > I can to say I tested this patch with gtk+ from git master. Yep :) I'll test it after I've done the build. I'm sure it's fine but I still need to test it. Thanks!
Review of attachment 267083 [details] [review]: Pushed as d729882 - Fix the about dialog when headerbar is used