After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722866 - rtspsrc: add rtpjitterbuffer do-retransmission property
rtspsrc: add rtpjitterbuffer do-retransmission property
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
git master
Other Linux
: Normal enhancement
: 1.3.1
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-23 23:20 UTC by Aleix Conchillo Flaqué
Modified: 2014-01-24 15:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add do-retransmission property (3.99 KB, patch)
2014-01-23 23:23 UTC, Aleix Conchillo Flaqué 		committed Details | Review

Description Aleix Conchillo Flaqué 2014-01-23 23:20:00 UTC 
Simply add the do-retransmission property from rtpjitterbuffer so we can play with the new RTP RTX elements in rtspsrc.
Comment 1 Aleix Conchillo Flaqué 2014-01-23 23:23:12 UTC 
Created attachment 267081 [details] [review]
add do-retransmission property

Make rtpjitterbuffer do-retransmission property available in rtspsrc.
Comment 2 Sebastian Dröge (slomo) 2014-01-24 08:16:12 UTC 
commit 9f7b1128b1f00a2b87a232ff890867549ab95ba5
Author: Aleix Conchillo Flaqué <aleix@oblong.com>
Date:   Thu Jan 23 15:17:58 2014 -0800

    rtspsrc: Proxy rtpjitterbuffer do-retransmission property
    
    https://bugzilla.gnome.org/show_bug.cgi?id=722866
Comment 3 Olivier Crête 2014-01-24 08:26:47 UTC 
Why do you have a property to rtspsrc? Shouldn't it just automatically turn it on if the RTX codecs are in the SDP ?
Comment 4 Sebastian Dröge (slomo) 2014-01-24 08:33:28 UTC 
Do you want to always enable it if it's in the SDP? Maybe this should be an enum with an "auto" mode instead?
Comment 5 Wim Taymans 2014-01-24 08:41:22 UTC 
Let's not do this, it should 1) be automatically 2) we can't just keep on proxying these jitterbuffer properties.

I would rather have a new-rtpbin signal that notifies you when an rtpbin was added and then you can configure the RTX elements and the jitterbuffer properties (with the new-jitterbuffer signal).
Comment 6 Wim Taymans 2014-01-24 09:25:31 UTC 
commit 43feb82feb30192ca973949502d81318fb0ca9a7
Author: Wim Taymans <wtaymans@redhat.com>
Date:   Fri Jan 24 10:21:11 2014 +0100

    rtspsrc: add signal to notify of new manager
    
    So that you can configure and connect to signals on the rtpbin.
    
    See https://bugzilla.gnome.org/show_bug.cgi?id=722866
Comment 7 Aleix Conchillo Flaqué 2014-01-24 15:28:36 UTC 
(In reply to comment #5)
> Let's not do this, it should 1) be automatically 2) we can't just keep on
> proxying these jitterbuffer properties.
> 
> I would rather have a new-rtpbin signal that notifies you when an rtpbin was
> added and then you can configure the RTX elements and the jitterbuffer
> properties (with the new-jitterbuffer signal).

Much better. Thanks!

Marking as resolved.