After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722817 - Add gobject-introspection for GdkWin32
Add gobject-introspection for GdkWin32
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
3.11.x
Other Windows
: Normal trivial
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2014-01-23 06:01 UTC by LRN
Modified: 2014-04-04 10:39 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Builds introspection for gdkwin32 (gtk3) (2.00 KB, patch)
2014-01-23 06:05 UTC, LRN 		none Details | Review
give CC environment variable to the gir scanner (786 bytes, patch)
2014-01-23 06:07 UTC, LRN 		none Details | Review
Put GTK DLL into PATH for the scanner (418 bytes, patch)
2014-01-23 06:09 UTC, LRN 		none Details | Review
Introspection for gdk-win32 (2.54 KB, patch)
2014-03-28 16:32 UTC, LRN 		none Details | Review
Give CC to instrospection scanner (1.23 KB, patch)
2014-03-28 16:32 UTC, LRN 		committed Details | Review
Introspection for gdk-win32 (v2, fixed whitespace) (2.42 KB, patch)
2014-04-01 11:53 UTC, LRN 		needs-work Details | Review
Introspection for gdk-win32 (v2, REALLY fixed whitespace this time) (2.44 KB, patch)
2014-04-01 12:33 UTC, LRN 		committed Details | Review

Description LRN 2014-01-23 06:01:59 UTC 
Introspection is built for X11 backend of GDK, but not for the W32 backend.
Comment 1 LRN 2014-01-23 06:05:09 UTC 
Created attachment 267020 [details] [review]
Builds introspection for gdkwin32 (gtk3)

This works for gtk+-3.0-3.11.4.
I have a gtk2 version, if anyone is interested.
Comment 2 LRN 2014-01-23 06:07:41 UTC 
Created attachment 267021 [details] [review]
give CC environment variable to the gir scanner

gir scanner runs CC, make sure it gets the right one.
Comment 3 LRN 2014-01-23 06:09:00 UTC 
Created attachment 267022 [details] [review]
Put GTK DLL into PATH for the scanner

gir builds a program that is linked to gtk, then runs it. It needs gtk to be in PATH to work correctly.
Comment 4 LRN 2014-03-28 16:32:09 UTC 
Created attachment 273182 [details] [review]
Introspection for gdk-win32
Comment 5 LRN 2014-03-28 16:32:32 UTC 
Created attachment 273183 [details] [review]
Give CC to instrospection scanner

Introspection scanner-generation script gets compiler from the CC
environment, we need to set it.
Comment 6 LRN 2014-03-28 16:33:16 UTC 
The DLL PATH patch seems to be unnecessary these days, which is good, i've always thought it to be a bit too hacky.
Comment 7 LRN 2014-04-01 11:53:18 UTC 
Created attachment 273395 [details] [review]
Introspection for gdk-win32 (v2, fixed whitespace)
Comment 8 Ignacio Casal Quinteiro (nacho) 2014-04-01 12:29:56 UTC 
Review of attachment 273395 [details] [review]:

See the comment.

::: gdk/Makefile.am
@@ +276,3 @@
+if OS_WIN32
+w32_introspection_files = 		\
+	win32/gdkcursor-win32.c \

see that in the rest of the file all the \ are aligned using tabs, I think we should do the same here.
Comment 9 LRN 2014-04-01 12:33:25 UTC 
Created attachment 273396 [details] [review]
Introspection for gdk-win32 (v2, REALLY fixed whitespace this time)
Comment 10 Ignacio Casal Quinteiro (nacho) 2014-04-01 12:34:31 UTC 
Review of attachment 273396 [details] [review]:

Looks good.
Comment 11 LRN 2014-04-04 10:39:17 UTC 
Attachment 273396 [details] pushed as 4b80aa1 - Introspection for gdk-win32
Attachment 273183 [details] pushed as 0d53a58 - Give CC to instrospection scanner