After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722787 - BackgroundManager: don't destroy the newly created actor
BackgroundManager: don't destroy the newly created actor
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: background
unspecified
Other All
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-22 19:21 UTC by Giovanni Campagna
Modified: 2014-01-22 19:35 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
BackgroundManager: don't destroy the newly created actor (1.89 KB, patch)
2014-01-22 19:21 UTC, Giovanni Campagna
committed Details | Review

Description Giovanni Campagna 2014-01-22 19:21:14 UTC
Because we were setting this.background before calling .destroy(),
the call that was meant to destroy the old background was actually
destroying the new one!
Comment 1 Giovanni Campagna 2014-01-22 19:21:17 UTC
Created attachment 266995 [details] [review]
BackgroundManager: don't destroy the newly created actor
Comment 2 Jasper St. Pierre (not reading bugmail) 2014-01-22 19:31:22 UTC
Review of attachment 266995 [details] [review]:

Makes sense.
Comment 3 Giovanni Campagna 2014-01-22 19:35:34 UTC
Attachment 266995 [details] pushed as 816f516 - BackgroundManager: don't destroy the newly created actor