GNOME Bugzilla – Bug 722764
rawparse: fix SEEKING query handling
Last modified: 2014-12-12 20:25:55 UTC
Created attachment 266972 [details] [review] fix seeking query handling at rawparse When playing a pcm included media, rawparse return negative value. Although media can do seek, the result of seeking query was not seekable. Thus I add codes for this case, before convert to byte type query, rawparse ask peerpad query to upstream. I was checked with PCM/WAV contents with file base playback and http streaming playback.
Comment on attachment 266972 [details] [review] fix seeking query handling at rawparse I think this should always ask upstream first, independent of the format. Otherwise this looks correct, thanks :) Can you prepare a new patch for that?
Created attachment 290676 [details] [review] ask seeking query to upstream first I agree with that, and change to ask seeking query at first
I don't entirely understand yet in what situation this didn't work right before? What was the seeking query that was not answered correctly? What format was it in? What was the source?
Nevermind, I can think of a scenario. Pushed the patch with minor changes: if upstream handled the query, it also set the correct range values already, so no need for us to do that, and we might actually unset some value that upstream set (like a stop/duration value). commit aa2ecf5e53837f059c79330121aa305e843dc9bb Author: Wonchul Lee <wonchul86.lee@lge.com> Date: Fri Nov 14 10:55:14 2014 +0900 rawparse: send SEEKING query upstream first Sometimes rawparse does not handle the seeking query properly, the rawparse should send the query upstream first. For example, upstream could support seeking in TIME format (but not in BYTE format), so the BYTE format seeking query that rawparse sends in push mode would fail. https://bugzilla.gnome.org/show_bug.cgi?id=722764
Cherry-picked into 1.4 branch.