After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722753 - numlock LED for hotplugged keyboards not updated
numlock LED for hotplugged keyboards not updated
Status: RESOLVED FIXED
Product: gnome-settings-daemon
Classification: Core
Component: keyboard
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Rui Matos
gnome-settings-daemon-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-22 04:23 UTC by Peter Hutterer
Modified: 2014-01-28 14:53 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
keyboard: Apply num-lock to newly connected keyboards (1.58 KB, patch)
2014-01-28 11:12 UTC, Bastien Nocera
committed Details | Review

Description Peter Hutterer 2014-01-22 04:23:59 UTC
before 34395459cc8f0da6f163736743bced441ef86390, apply_all_settings() and then apply_numlock() would sync up the numlock LED on a newly hotplugged device. 34395459cc8f0da6f163736743bced441ef86390 removed that call, so devices now come up with the numlock LED off even when the numlock is on, and a subsequent state change will wrongly toggle it, i.e. LED off when numlock is on, LED on when numlock is off.

This should really be fixed in the xserver but it's unlikely to happen, restoring this patch in gnome seems the simplest solution for now.
Comment 1 Bastien Nocera 2014-01-28 11:12:49 UTC
Created attachment 267393 [details] [review]
keyboard: Apply num-lock to newly connected keyboards

before 34395459cc8f0da6f163736743bced441ef86390, apply_all_settings()
and then apply_numlock() would sync up the numlock LED on a newly
hotplugged device.
34395459cc8f0da6f163736743bced441ef86390 removed that call, so devices
now come up with the numlock LED off even when the numlock is on, and a
subsequent state change will wrongly toggle it, i.e. LED off when numlock
is on, LED on when numlock is off.

This should really be fixed in the xserver but it's unlikely to happen,
restoring this patch in gnome-settings-daemon seems the simplest solution
for now.
Comment 2 Rui Matos 2014-01-28 12:47:06 UTC
Review of attachment 267393 [details] [review]:

ok
Comment 3 Bastien Nocera 2014-01-28 14:53:37 UTC
Attachment 267393 [details] pushed as 5081082 - keyboard: Apply num-lock to newly connected keyboards