After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722752 - Pass invalid argument 'timestamp' for pushModal function
Pass invalid argument 'timestamp' for pushModal function
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
: 765033 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2014-01-22 02:43 UTC by Heiher
Modified: 2016-04-14 09:13 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix patch file (1.29 KB, patch)
2014-01-22 02:43 UTC, Heiher 		none Details | Review
Fix patch file v2 (1.29 KB, patch)
2014-01-22 02:53 UTC, Heiher 		none Details | Review
modalDialog: Fix invalid argument 'timestamp' for pushModal (1.32 KB, patch)
2016-04-14 09:11 UTC, Florian Müllner 		committed Details | Review

Description Heiher 2014-01-22 02:43:54 UTC 
Created attachment 266941 [details] [review]
Fix patch file

Pass invalid argument 'timestamp' for pushModal function in js/ui/modalDialog.js.
Comment 1 Heiher 2014-01-22 02:53:48 UTC 
Created attachment 266942 [details] [review]
Fix patch file v2
Comment 2 Florian Müllner 2015-03-19 00:51:51 UTC 
Review of attachment 266942 [details] [review]:

Sorry for the late respose, somehow this patch fell through the cracks ...

::: js/ui/modalDialog.js
@@ +357,3 @@
             return true;
+
+        let params = { keybindingMode: this._keybindingMode };

keybindingMode has been renamed to actionMode a while ago, looks good to me otherwise
Comment 3 Florian Müllner 2016-04-14 09:11:07 UTC 
Created attachment 325983 [details] [review]
modalDialog: Fix invalid argument 'timestamp' for pushModal

Updated patch according to comment #2.
Comment 4 Florian Müllner 2016-04-14 09:12:19 UTC 
Attachment 325983 [details] pushed as a23b293 - modalDialog: Fix invalid argument 'timestamp' for pushModal
Comment 5 Florian Müllner 2016-04-14 09:13:39 UTC 
*** Bug 765033 has been marked as a duplicate of this bug. ***