After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722737 - encoder: h264: only submit packed headers if required by the VA driver
encoder: h264: only submit packed headers if required by the VA driver
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
Depends on:
Blocks: 720305
 
 
Reported: 2014-01-21 22:48 UTC by Gwenole Beauchesne
Modified: 2014-01-22 18:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Gwenole Beauchesne 2014-01-21 22:48:23 UTC 
The VAConfigAttribEncPackedHeaders attribute notifies the application whether packed headers are needed by the VA driver or if it is able to pack those itself. It looks useless to forcibly generate and submit those packed headers if the driver doesn't care of them.

Likewise, it is not needed to submit VAEncSequenceParameterBufferH264 for each frame. This would avoid initialization, copies et al. of 1KB/frame.
Comment 1 Gwenole Beauchesne 2014-01-22 18:12:48 UTC 
commit 1e502d63d5a5634e2de986a6d749c8e659d0e959
Author: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Date:   Tue Jan 21 18:01:20 2014 +0100

    encoder: h264: submit sequence parameter only once.
    
    Submit sequence parameter buffers only once, or when the bitstream
    was reconfigured in a way that requires such. Always submit packed
    sequence parameter buffers at I-frame period, if the VA driver needs
    those.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=722737

commit 71113e4999328bde8b34b0cf713f80e7e106cf43
Author: Gwenole Beauchesne <gwenole.beauchesne@intel.com>
Date:   Tue Jan 21 18:35:17 2014 +0100

    encoder: h264: only submit packed headers when required.
    
    Make sure to submit the packed headers only if the underlying VA driver
    requires those. Currently, only handle packed sequence and picture
    headers.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=722737