After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722728 - JS ERROR: TypeError: room.channel is null
JS ERROR: TypeError: room.channel is null
Status: RESOLVED FIXED
Product: polari
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Polari maintainers
Polari maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-21 20:56 UTC by Maciej (Matthew) Piechotka
Modified: 2014-02-22 00:22 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
app: Properly cancel pending requests when necessary (4.47 KB, patch)
2014-02-22 00:20 UTC, Florian Müllner 		committed Details | Review

Description Maciej (Matthew) Piechotka 2014-01-21 20:56:10 UTC 
When I entered a room on another server by accident polari started connecting to it. Then when I left the channel while it was connection the JS error occured:

(polari:10133): Gjs-WARNING **: JS ERROR: TypeError: room.channel is null
Application<._onLeaveRoom@/usr/share/polari/js/application.js:361
wrapper@/usr/share/gjs-1.0/lang.js:213
RoomList<._onLeaveSelectedActivated@/usr/share/polari/js/roomList.js:217
wrapper@/usr/share/gjs-1.0/lang.js:213
start@/usr/share/polari/js/main.js:8
@<command line>:1
Comment 1 Florian Müllner 2014-02-22 00:20:51 UTC 
Created attachment 269964 [details] [review]
app: Properly cancel pending requests when necessary

Joining a room can take a while, in particular when we still have
to connect to the server first. If the connection is interrupted
while the request is still ongoing, either by leaving the room
or by exiting Polari altogether, we will currently spill some ugly
warnings, and telepathy may transfer the request to another handler
like Empathy.
Avoid these problems by keeping track of ongoing requests and cancel
them cleanly in those cases.
Comment 2 Florian Müllner 2014-02-22 00:22:00 UTC 
Attachment 269964 [details] pushed as 7c26479 - app: Properly cancel pending requests when necessary