After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722658 - Extend the app-folders schema
Extend the app-folders schema
Status: RESOLVED FIXED
Product: gsettings-desktop-schemas
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: gsettings-desktop-schemas-maint
gsettings-desktop-schemas-maint
Depends on:
Blocks: 722659
 
 
Reported: 2014-01-20 22:05 UTC by Matthias Clasen
Modified: 2014-01-21 12:45 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Extend the app-folders schema (1.70 KB, patch)
2014-01-20 22:05 UTC, Matthias Clasen
needs-work Details | Review
Extend the app-folders schema (1.99 KB, patch)
2014-01-21 11:00 UTC, Matthias Clasen
committed Details | Review

Description Matthias Clasen 2014-01-20 22:05:54 UTC
To replace the previous functionality of having default folders
for (some) categories, we need add some more keys to app-folder
schema.

The categories key defines a list of categories that should be
put into the folder by default.

The excluded-apps key provides a way to override the placement
by categories for individual apps.
Comment 1 Matthias Clasen 2014-01-20 22:05:56 UTC
Created attachment 266814 [details] [review]
Extend the app-folders schema
Comment 2 Bastien Nocera 2014-01-21 06:53:59 UTC
Review of attachment 266814 [details] [review]:

The documentation for those is a bit unclear. I'm fine with adding the keys though.

::: schemas/org.gnome.desktop.app-folders.gschema.xml.in.in
@@ +31,3 @@
+      <_summary>Categories</_summary>
+      <_description>A list of categories for which apps will be placed
+      into this folder by default.</_description>

Is this in addition to the apps listed in "apps", or does one take preference?

@@ +38,3 @@
+      <_description>The list of ids of applications that are excluded
+      from this folder. This can be used to remove applications that
+      would otherwise be included by category.</_description>

Is that only for Category based inclusion, or for apps listed in "apps" as well?
Comment 3 Matthias Clasen 2014-01-21 11:00:10 UTC
Here is the algorithm I gave to Jasper for finding all the apps that go in a folder:

1. Take all the apps that have one of the categories listed in the categories key
2. Add all the apps that are listed in the apps key
3. Remove all the apps that are listed in the excluded_apps key
Comment 4 Matthias Clasen 2014-01-21 11:00:28 UTC
Created attachment 266847 [details] [review]
Extend the app-folders schema

To replace the previous functionality of having default folders
for (some) categories, we need add some more keys to app-folder
schema.

The categories key defines a list of categories that should be
put into the folder by default.

The excluded-apps key provides a way to override the placement
by categories for individual apps.
Comment 5 Bastien Nocera 2014-01-21 11:04:25 UTC
Review of attachment 266847 [details] [review]:

++
Comment 6 Matthias Clasen 2014-01-21 12:45:47 UTC
Attachment 266847 [details] pushed as 0402d1f - Extend the app-folders schema