After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722624 - Correct styling for all tab locations
Correct styling for all tab locations
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: Adwaita GTK3 theme
git master
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-20 17:45 UTC by lamefun
Modified: 2014-01-20 17:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Correct styling for all tab locations (2.08 KB, patch)
2014-01-20 17:45 UTC, lamefun 		committed Details | Review
Comparison screenshot (20.88 KB, image/png)
2014-01-20 17:46 UTC, lamefun 		  Details

Description lamefun 2014-01-20 17:45:51 UTC 
Created attachment 266766 [details] [review]
Correct styling for all tab locations

patch
Comment 1 lamefun 2014-01-20 17:46:12 UTC 
Created attachment 266767 [details]
Comparison screenshot
Comment 2 Hashem Nasarat 2014-01-20 17:51:58 UTC 
Review of attachment 266766 [details] [review]:

Nice patch, but your commit message does not describe why the change was made. As such, people who follow updates to the git repository will be confused about why this patch has been added, or what changes to look for.

See https://wiki.openstack.org/wiki/GitCommitMessages#Information_in_commit_messages for ideas for improvement.

Something like "previously, the tab highlight was always on the bottom regardless of the tab orientation. Now the tab highlight location changes with the tab location"