After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722599 - Add JPEG 2000 and PNM to the list of content_types
Add JPEG 2000 and PNM to the list of content_types
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: Background
unspecified
Other All
: Normal normal
: ---
Assigned To: Debarshi Ray
Control-Center Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-20 12:55 UTC by Debarshi Ray
Modified: 2014-01-20 16:52 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
background: Add PNM to the list of valid content types (731 bytes, patch)
2014-01-20 12:57 UTC, Debarshi Ray
committed Details | Review
background: Add JPEG 2000 to the list of valid content types (760 bytes, patch)
2014-01-20 13:56 UTC, Debarshi Ray
committed Details | Review

Description Debarshi Ray 2014-01-20 12:55:14 UTC
PNM or the Portable Anymap Format [1] is a valid content type for wallpapers. Here are some sample PNM images: http://sourceforge.net/projects/jpeg/files/jpeg2000_images/jpeg2000_images/

[1] https://en.wikipedia.org/wiki/Netpbm_format
Comment 1 Debarshi Ray 2014-01-20 12:57:33 UTC
Created attachment 266724 [details] [review]
background: Add PNM to the list of valid content types
Comment 2 Bastien Nocera 2014-01-20 13:11:18 UTC
Review of attachment 266724 [details] [review]:

I don't think we want PNM files to show up in the background panel. The PNM files in those packages are there to provide a lossless version of the JPEG2k files.

That being said, the patch is easily revertible should we find that it causes problems.
Comment 3 Debarshi Ray 2014-01-20 13:47:05 UTC
... and we need to add JPEG 2000 too.
Comment 4 Debarshi Ray 2014-01-20 13:56:08 UTC
Created attachment 266734 [details] [review]
background: Add JPEG 2000 to the list of valid content types
Comment 5 Debarshi Ray 2014-01-20 14:01:22 UTC
From #control-center on GIMPNet:
<hadess> rishi, jpeg2k could show up in the background panel, just commit a patch to that effect
Comment 6 Bastien Nocera 2014-01-20 14:03:03 UTC
Review of attachment 266734 [details] [review]:

++