After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722594 - [PATCH] Fail to build gdm on FreeBSD
[PATCH] Fail to build gdm on FreeBSD
Product: gdm
Classification: Core
Component: general
Other FreeBSD
: Normal normal
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Reported: 2014-01-20 10:22 UTC by Ting-Wei Lan
Modified: 2014-02-13 12:14 UTC
See Also:
GNOME target: ---
GNOME version: ---

Fix build problem on FreeBSD (1.43 KB, patch)
2014-01-20 10:22 UTC, Ting-Wei Lan
committed Details | Review

Description Ting-Wei Lan 2014-01-20 10:22:55 UTC
Created attachment 266710 [details] [review]
Fix build problem on FreeBSD

I cannot build gdm on FreeBSD because of several problems.

 1. -lutil is missing when linking gdm-session-worker. (daemon/
 2. #include <sys/types.h> is missing in daemon/gdm-session.h.
 3. #include <netinet/in.h> is missing in daemon/gdm-xdmcp-display-factory.c.
Comment 1 Allison Karlitskaya (desrt) 2014-02-13 12:10:23 UTC
While looking at this patch I notice that this EXTRA_DAEMON_LIBS thing is a bit strange.  See this comment:

# Note that these libs are in LDFLAGS because they should come before
# everything else on the link line as they may override stuff
gdm_LDFLAGS =                           \
        $(EXTRA_DAEMON_LIBS)                    \

This was introduced as a hack in order to fix bug 85785, but these days usage within even this one Makefile is inconsistent.  I think it's probably worth removing this at this point, and possibly removing the distinction between EXTRA_DAEMON_LIBS and DAEMON_LIBS entirely.
Comment 2 Allison Karlitskaya (desrt) 2014-02-13 12:14:42 UTC
Attachment 266710 [details] pushed as 2d02525 - Fix build problem on FreeBSD

(In reply to comment #1)
> I notice that this EXTRA_DAEMON_LIBS thing is a bit strange.
    -> bug 724283.