After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722553 - GtkMenuTrackerItem and friends should use GRemoteActionGroup
GtkMenuTrackerItem and friends should use GRemoteActionGroup
Status: RESOLVED WONTFIX
Product: gtk+
Classification: Platform
Component: Class: GtkApplication
unspecified
Other All
: Normal normal
: ---
Assigned To: gtkdev
gtkdev
Depends on:
Blocks:
 
 
Reported: 2014-01-19 17:20 UTC by Giovanni Campagna
Modified: 2014-01-28 20:55 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
gtkactionmuxer: implement GRemoteActionGroup (6.31 KB, patch)
2014-01-19 17:20 UTC, Giovanni Campagna 		none Details | Review
GtkMenuTrackerItem: make use of GRemoteActionGroup (4.20 KB, patch)
2014-01-19 17:20 UTC, Giovanni Campagna 		none Details | Review

Description Giovanni Campagna 2014-01-19 17:20:50 UTC 
Just syncing code changes that I made for gnome-shell with the
master copy in gtk+.
Comment 1 Giovanni Campagna 2014-01-19 17:20:54 UTC 
Created attachment 266660 [details] [review]
gtkactionmuxer: implement GRemoteActionGroup

By forwarding to a GRemoteActionGroup if one is inserted in the
muxer, or dropping the platform_data on the floor.

GTK+ internally does not use remote actions, but this keeps the
code consistent with gnome-shell.
Comment 2 Giovanni Campagna 2014-01-19 17:20:58 UTC 
Created attachment 266661 [details] [review]
GtkMenuTrackerItem: make use of GRemoteActionGroup

When the observable is a GtkActionMuxer, use the GRemoteActionGroup
interface to pass down to the timestamp for the even to the
implementation.
The timestamp is added to the API to allow sharing the file
with gnome-shell.
Comment 3 Jasper St. Pierre (not reading bugmail) 2014-01-19 17:45:12 UTC 
CCing desrt for review.
Comment 4 Jasper St. Pierre (not reading bugmail) 2014-01-24 22:32:55 UTC 
desrt didn't like these patches, so I'm going to WONTFIX them.
Comment 5 Giovanni Campagna 2014-01-28 20:17:23 UTC 
(In reply to comment #4)
> desrt didn't like these patches, so I'm going to WONTFIX them.

I'd like to know why.
Comment 6 Jasper St. Pierre (not reading bugmail) 2014-01-28 20:54:54 UTC 
He felt that "platform data" should not be injected into the high-level APIs, but at a place low in the stack, and pointed me to https://bugzilla.gnome.org/show_bug.cgi?id=697994 . You're free to continue those patches.