After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722520 - Non-void function should return a value
Non-void function should return a value
Status: RESOLVED FIXED
Product: bijiben
Classification: Applications
Component: general
3.11.x
Other FreeBSD
: Normal normal
: ---
Assigned To: Bijiben maintainer(s)
Bijiben maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2014-01-19 03:39 UTC by Ting-Wei Lan
Modified: 2014-01-19 07:56 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Simple patch to fix the error (1.05 KB, patch)
2014-01-19 03:39 UTC, Ting-Wei Lan 		committed Details | Review

Description Ting-Wei Lan 2014-01-19 03:39:09 UTC 
Created attachment 266640 [details] [review]
Simple patch to fix the error

Some Non-void functions use g_return_if_fail, which should be replaced by
g_return_val_if_fail.

src/libbiji/biji-local-note.c: local_note_get_place
src/libbiji/provider/biji-own-cloud-note.c: ocloud_note_get_place
Comment 1 Pierre-Yves Luyten 2014-01-19 07:55:12 UTC 
Comment on attachment 266640 [details] [review]
Simple patch to fix the error

pushed as de41d9c257cc53bc287258d4bb71b142b0bffc8a
Comment 2 Pierre-Yves Luyten 2014-01-19 07:56:11 UTC 
Thanks, I pushed because i don't know if you have git access.