After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722514 - Drop margin-left and margin-right property and use margin-start and margin-end instead
Drop margin-left and margin-right property and use margin-start and margin-en...
Status: RESOLVED OBSOLETE
Product: glade
Classification: Applications
Component: general
git master
Other Mac OS
: Normal normal
: ---
Assigned To: Glade 3 Maintainers
Glade 3 Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-18 22:20 UTC by Yosef Or Boczko
Modified: 2018-03-26 15:34 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Yosef Or Boczko 2014-01-18 22:20:02 UTC
See bug 710238.
Comment 1 Tristan Van Berkom 2014-01-19 06:42:21 UTC
Ugh, well this will be a sticky ugly change.

Things to consider when making a patch for this:

  o We need to support the old properties for projects
    targetting versions of GTK+ which have the old properties

  o We probably dont want to clutter the UI with both versions
    of the said properties

  o Ideally editing a project that has "margin-right" &
    "margin-left", and when changing the target GTK+ version
    to a newer version that has "margin-start" "margin-end" available,
    we will want an undoable way to automatically convert these
    properties.
Comment 2 gnome.vrb 2016-09-21 05:15:52 UTC
It took me quite sometime to dig the history of margin-start / margin-end, and land here. I got a bit confused here ( thought margin-start / margin-end were new additional properties in addition to the other 4 properties ). Things became clear after looking into bug 710238.

FWIW, it would be great to at least add a deprecation warning, so that users will not use margin-left / margin-right moving forward. In its current state, glade seems to indirectly propagate the use of margin-left / margin-right ( though not intentional ), which gtk+ wants to badly avoid.
Comment 3 gnome.vrb 2016-09-21 05:29:20 UTC
Relevant bug: https://bugzilla.gnome.org/show_bug.cgi?id=744095
Comment 4 GNOME Infrastructure Team 2018-03-26 15:34:20 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/glade/issues/148.