After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722411 - Functions from gvfsdbusutils.c not found when using HAL backend
Functions from gvfsdbusutils.c not found when using HAL backend
Product: gvfs
Classification: Core
Component: [obsolete] hal volume monitor
git master
Other FreeBSD
: Normal normal
: ---
Assigned To: gvfs-maint
Depends on:
Reported: 2014-01-17 12:33 UTC by Ting-Wei Lan
Modified: 2015-04-01 17:27 UTC
See Also:
GNOME target: ---
GNOME version: ---

Simple patch to fix the error (31.98 KB, patch)
2014-01-17 12:33 UTC, Ting-Wei Lan
reviewed Details | Review
Updated patch (34.01 KB, patch)
2015-02-05 17:45 UTC, Ting-Wei Lan
none Details | Review
Updated patch with gvfsdbusutils.[ch] renamed to gvfshalutils.[ch] (34.78 KB, patch)
2015-04-01 17:09 UTC, Ting-Wei Lan
committed Details | Review

Description Ting-Wei Lan 2014-01-17 12:33:19 UTC
Created attachment 266544 [details] [review]
Simple patch to fix the error


These three files use the function _g_dbus_connection_integrate_with_main, which is defined in monitor/hal/gvfsdbusutils.c, but they connot find this function.
I move monitor/hal/gvfsdbusutils.c to common/gvfsdbusutils.c and modify some to solve this problem. Is it a correct way to resolve this issue?
Comment 1 Alexander Larsson 2014-01-23 13:03:41 UTC
In general this looks ok, but i'm a bit uncertain about the use of USE_HAL in common/ Not sure, but it seems this may be set if hal was detected, but gudev also was detected. I'd like to make sure we link in the dbus libs only if hal is actually *used*.
Comment 2 Alexander Larsson 2014-01-23 13:13:24 UTC
Actually i think we should put the libdbus helpers in a separate library and only link to that from the backends that require it. We don't want the other backends to pick up a libdbus backend.
Comment 3 Ondrej Holy 2014-01-29 20:14:05 UTC
Comment on attachment 266544 [details] [review]
Simple patch to fix the error

Marking as reviewed, because alex reviewed it already in previous comments...
Comment 4 Ting-Wei Lan 2015-02-05 17:45:36 UTC
Created attachment 296216 [details] [review]
Updated patch
Comment 5 Ross Lagerwall 2015-04-01 16:55:30 UTC
Review of attachment 296216 [details] [review]:

Looks fine (untested).

Just one thing, can you rename the libgvfscommon-dbus to libgvfscommon-hal, and gvfsdbusutils.* to gvfshalutils.*
This is so that it is clear that these are only for hal stuff and not general dbus stuff.
Comment 6 Ting-Wei Lan 2015-04-01 17:09:32 UTC
Created attachment 300770 [details] [review]
Updated patch with gvfsdbusutils.[ch] renamed to gvfshalutils.[ch]
Comment 7 Ross Lagerwall 2015-04-01 17:22:38 UTC
Review of attachment 300770 [details] [review]:

Comment 8 Ting-Wei Lan 2015-04-01 17:26:39 UTC
Attachment 300770 [details] pushed as 32377d1 - Fix build error when using HAL backend