After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722404 - cover more H.264 baseline profile clips of decoder
cover more H.264 baseline profile clips of decoder
Status: RESOLVED OBSOLETE
Product: GStreamer
Classification: Platform
Component: gstreamer-vaapi
unspecified
Other Linux
: Normal enhancement
: git master
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2014-01-17 09:46 UTC by Wind Yuan
Modified: 2018-11-03 15:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
h264-dec-add-more-checks-from-pps-for-hardware-profi.patch (2.82 KB, patch)
2014-01-17 09:46 UTC, Wind Yuan
none Details | Review
decoder: h264: more checks from pps for hw profile (3.43 KB, patch)
2016-02-04 16:41 UTC, Víctor Manuel Jáquez Leal
none Details | Review

Description Wind Yuan 2014-01-17 09:46:30 UTC
Created attachment 266538 [details] [review]
h264-dec-add-more-checks-from-pps-for-hardware-profi.patch

Since driver only support constrained-baseline profile of H.264 for decoder. all other baseline clips would be disabled. This broke most baseline clips which mark constraint_set1_flag=0 but actually don't have FMO/ASO/RS.
From spec, if num_slice_groups_minus1 of picture parameter is 0, FMO/ASO are disabled. If redundant_pic_cnt_present_flag disabled(=0) RS will not appear. Then if checked the 2 fields both set to 0, we can mark them as a constrained-baseline profile for hardware to decode, which can cover more clips for HW decoder.

Patch attached. please review.
Comment 1 Víctor Manuel Jáquez Leal 2016-02-04 16:41:35 UTC
Created attachment 320456 [details] [review]
decoder: h264: more checks from pps for hw profile

Baseline profile without constraint_set1_flag = 1, without
num_slice_groups_minus1 and redundant_pic_cnt_present_flag, still can fallback
hardware profile of constrained-baseline.

Since driver only supports constrained-baseline profile of H.264 for decoder,
all other baseline clips would be disabled. This broke most baseline clips
which mark constraint_set1_flag=0 but actually don't have FMO/ASO/RS.

From spec, if num_slice_groups_minus1 of picture parameter is 0, FMO/ASO are
disabled. If redundant_pic_cnt_present_flag disabled (=0) RS will not
appear. Then if checked the 2 fields both set to 0, we can mark them as a
constrained-baseline profile for hardware to decode, which can cover more
clips for decode.
Comment 2 Víctor Manuel Jáquez Leal 2016-02-04 16:43:15 UTC
I have rebased the patch, but I'm not sure if it is still valid since the current hardware supports more H264 profiles.

I would like to have some samples to test this feature.
Comment 3 sreerenj 2016-03-24 16:55:50 UTC
Moving to Product:GStreamer, Component:gstreamer-vaapi
Comment 4 GStreamer system administrator 2018-11-03 15:44:31 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to freedesktop.org's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.freedesktop.org/gstreamer/gstreamer-vaapi/issues/9.