After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722398 - core: Add unit to duration
core: Add unit to duration
Status: RESOLVED FIXED
Product: grilo
Classification: Other
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: grilo-maint
grilo-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-17 07:58 UTC by Bastien Nocera
Modified: 2014-02-03 19:02 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
core: Add unit to duration (1004 bytes, patch)
2014-01-17 07:58 UTC, Bastien Nocera
committed Details | Review
apple: Fix duration (930 bytes, patch)
2014-01-17 07:59 UTC, Bastien Nocera
committed Details | Review
apple-trailers: Fix tests (2.15 KB, patch)
2014-02-03 19:01 UTC, Juan A. Suarez Romero
committed Details | Review

Description Bastien Nocera 2014-01-17 07:58:28 UTC
.
Comment 1 Bastien Nocera 2014-01-17 07:58:36 UTC
Created attachment 266529 [details] [review]
core: Add unit to duration

Looking at the various sources, this is currently in seconds
Comment 2 Bastien Nocera 2014-01-17 07:59:32 UTC
Created attachment 266530 [details] [review]
apple: Fix duration

The length are in mins:secs not hours:mins.
Comment 3 Juan A. Suarez Romero 2014-02-03 18:46:21 UTC
Comment on attachment 266529 [details] [review]
core: Add unit to duration

commit 8654445fae39768fcf776656e9c95133b21d9627
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri Jan 17 08:57:07 2014 +0100

    doc: Add unit to duration
    
    Looking at the various sources, this is currently in seconds
    
    https://bugzilla.gnome.org/show_bug.cgi?id=722398

 src/data/grl-media.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
Comment 4 Juan A. Suarez Romero 2014-02-03 18:58:56 UTC
Comment on attachment 266530 [details] [review]
apple: Fix duration

commit 9ad7bfd2f117a8b2e053861d9f8afdbf681e9bf5
Author: Bastien Nocera <hadess@hadess.net>
Date:   Fri Jan 17 08:58:48 2014 +0100

    apple-trailers: Fix duration
    
    The length are in mins:secs not hours:mins.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=722398

 src/apple-trailers/grl-apple-trailers.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 5 Juan A. Suarez Romero 2014-02-03 19:01:55 UTC
Created attachment 267993 [details] [review]
apple-trailers: Fix tests

Duration come as minutes:seconds, not hours:minutes.
Comment 6 Juan A. Suarez Romero 2014-02-03 19:02:49 UTC
Author: Juan A. Suarez Romero <jasuarez@igalia.com>
Date:   Mon Feb 3 19:00:51 2014 +0000

    apple-trailers: Fix tests
    
    Duration come as minutes:seconds, not hours:minutes.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=722398

 tests/apple-trailers/test_apple_trailers.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)