After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722390 - vaapisink: implement the GstColorBalance interface
vaapisink: implement the GstColorBalance interface
Status: RESOLVED FIXED
Product: gstreamer-vaapi
Classification: Other
Component: general
0.5.8
Other Linux
: Normal enhancement
: ---
Assigned To: gstreamer-vaapi maintainer(s)
gstreamer-vaapi maintainer(s)
: 719414 (view as bug list)
Depends on:
Blocks: 731852
 
 
Reported: 2014-01-17 05:34 UTC by changzhix.wei@intel.com
Modified: 2014-07-31 16:51 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
vaapisink: implement the GstColorBalance interface (10.12 KB, patch)
2014-01-17 05:34 UTC, changzhix.wei@intel.com 		none Details | Review
vaapisink: add colorbalance to property (7.26 KB, patch)
2014-01-23 02:33 UTC, changzhix.wei@intel.com 		none Details | Review
vaapisink: add gstcolorbalance interface (12.43 KB, patch)
2014-01-23 02:34 UTC, changzhix.wei@intel.com 		none Details | Review
vaapisink: add colorbalance to property (7.58 KB, patch)
2014-01-23 08:58 UTC, changzhix.wei@intel.com 		none Details | Review
vaapisink: add GstColorBalance interface (12.48 KB, patch)
2014-01-23 09:00 UTC, changzhix.wei@intel.com 		none Details | Review

Description changzhix.wei@intel.com 2014-01-17 05:34:24 UTC 
Created attachment 266522 [details] [review]
vaapisink: implement the GstColorBalance interface

add GstColorBalance support: hue/saturation/brightness/contrast
Comment 1 Gwenole Beauchesne 2014-01-17 06:16:21 UTC 
*** Bug 719414 has been marked as a duplicate of this bug. ***
Comment 2 Gwenole Beauchesne 2014-01-17 06:17:57 UTC 
This is a duplicate of bug #719414 but closed the other to keep the patch flow here. Thanks.
Comment 3 Gwenole Beauchesne 2014-01-17 06:33:54 UTC 
You need to implement the GstColorBalance interface instead.
Comment 4 Gwenole Beauchesne 2014-01-17 06:35:10 UTC 
Review of attachment 266522 [details] [review]:

There are {get,set}_attribute() helpers to use.
Comment 5 changzhix.wei@intel.com 2014-01-23 02:33:04 UTC 
Created attachment 267013 [details] [review]
vaapisink: add colorbalance to property

add GstColorBalance property: hue/saturation/brightness/contrast
Comment 6 changzhix.wei@intel.com 2014-01-23 02:34:19 UTC 
Created attachment 267014 [details] [review]
vaapisink: add gstcolorbalance interface

add GstColorBalance interface: hue/saturation/brightness/contrast
Comment 7 changzhix.wei@intel.com 2014-01-23 08:58:48 UTC 
Created attachment 267029 [details] [review]
vaapisink: add colorbalance to property

add GstColorBalance property: hue/saturation/brightness/contrast
Comment 8 changzhix.wei@intel.com 2014-01-23 09:00:55 UTC 
Created attachment 267030 [details] [review]
vaapisink: add GstColorBalance interface

add GstColorBalance interface: hue/saturation/brightness/contrast
Comment 9 Gwenole Beauchesne 2014-07-31 16:51:00 UTC 
commit c201f738fe535d94c6526c38d1a7f205c3f32241
Author: Changzhi Wei <changzhix.wei@intel.com>
Date:   Thu Jan 23 15:44:09 2014 +0000

    vaapisink: add support for GstColorBalance interface.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=722390
    
    [fixed channel names, simplified range factor, fixed memory leak]
    Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>

commit 5a95cd564562974a3d65b2605a7bb26441ecf322
Author: Changzhi Wei <changzhix.wei@intel.com>
Date:   Thu Jan 23 15:23:00 2014 +0000

    vaapisink: add support for colorbalance adjustment.
    
    https://bugzilla.gnome.org/show_bug.cgi?id=722390
    
    [fixed and simplified tracking of colorbalance value changes]
    Signed-off-by: Gwenole Beauchesne <gwenole.beauchesne@intel.com>