After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 722366 - provide affordance for reorderable tabs
provide affordance for reorderable tabs
Status: RESOLVED FIXED
Product: gnome-themes-standard
Classification: Core
Component: Adwaita GTK3 theme
3.11.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-themes-standard-maint
gnome-themes-standard-maint
Depends on:
Blocks:
 
 
Reported: 2014-01-16 18:46 UTC by Jakub Steiner
Modified: 2014-02-06 22:11 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tabs: separators for reorderable tabs (1006 bytes, patch)
2014-01-16 18:47 UTC, Jakub Steiner
committed Details | Review

Description Jakub Steiner 2014-01-16 18:46:19 UTC
We should provide a hint of separation between reorderable tabs.
Comment 1 Jakub Steiner 2014-01-16 18:47:40 UTC
Created attachment 266495 [details] [review]
tabs: separators for reorderable tabs
Comment 2 Jakub Steiner 2014-01-16 18:49:20 UTC
The patch doesn't do much as we don't class the reorderable tabs and it also falls short when tabs overflow. Suddenly the last tab is out of view and the separator is drawn on the right.
Comment 4 Jakub Steiner 2014-01-17 14:23:38 UTC
Attachment 266495 [details] pushed as df01302 - tabs: separators for reorderable tabs
Comment 5 Jakub Steiner 2014-01-21 11:15:28 UTC
pushed/closed by mistake :/ Still need the tabs to be classed on the gtk side.
Comment 6 Matthias Clasen 2014-02-06 22:10:41 UTC
We now have

      if (page->reorderable)
        gtk_style_context_add_class (context, "reorderable-page");